Closed Bug 923607 Opened 10 years ago Closed 10 years ago

Marionette should suppress safe-mode dialog when starting in safe-mode

Categories

(Remote Protocol :: Marionette, defect)

Product:
Remote Protocol
Component:
Marionette
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox25 wontfix, firefox26 wontfix, firefox27 fixed, b2g-v1.2 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla27
Tracking Flags:
Tracking Status
firefox25 --- wontfix
firefox26 --- wontfix
firefox27 --- fixed
b2g-v1.2 --- fixed

People

(Reporter: ttaubert, Assigned: ttaubert)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Suppress safe-mode dialog when starting in safe-mode
2.51 KB, patch
automatedtester
: review+
Details | Diff | Splinter Review 
For SessionStore, I'd really like to write a test that covers bug 919532. Marionette runs fine in safe-mode but is blocked by a modal dialog shown early at startup. I think it would be good to always take care of that automatically when running Marionette tests.
Comment on attachment 813685 [details] [diff] [review]
Suppress safe-mode dialog when starting in safe-mode

Mind running this through try?

try: -b do -p linux,macosx64,win32,emulator,panda -u marionette, marionette-webapi -t none
Means that there is no preference we could set?
No, there's no such preference:

https://mxr.mozilla.org/mozilla-central/source/browser/components/nsBrowserGlue.js#452

We could of course add one if we think that's the better solution. I personally am not a big fan of sprinkling debug/testing code everywhere but it also seems like it wouldn't hurt that much here.
Comment on attachment 813685 [details] [diff] [review]
Suppress safe-mode dialog when starting in safe-mode

Review of attachment 813685 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry for the late review, looks good!
Attachment #813685 - Flags: review?(dburns) → review+
https://hg.mozilla.org/mozilla-central/rev/7b19a91810cd
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → mozilla27
Product: Testing → Remote Protocol
You need to log in before you can comment on or make changes to this bug.