923607 - Marionette should suppress safe-mode dialog when starting in safe-mode

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[Tim Taubert [:ttaubert] (inactive)]

For SessionStore, I'd really like to write a test that covers bug 919532. Marionette runs fine in safe-mode but is blocked by a modal dialog shown early at startup. I think it would be good to always take care of that automatically when running Marionette tests.

Comment 1

[Tim Taubert [:ttaubert] (inactive)]

Attachment: Suppress safe-mode dialog when starting in safe-mode

Comment 2

[David Burns :automatedtester]

Comment on attachment 813685 [details] [diff] [review]
Suppress safe-mode dialog when starting in safe-mode

Mind running this through try?

try: -b do -p linux,macosx64,win32,emulator,panda -u marionette, marionette-webapi -t none

Comment 3

[Tim Taubert [:ttaubert] (inactive)]

Pushed to try:

https://tbpl.mozilla.org/?tree=Try&rev=c0e170af5d3c

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Means that there is no preference we could set?

Comment 5

[Tim Taubert [:ttaubert] (inactive)]

No, there's no such preference:

https://mxr.mozilla.org/mozilla-central/source/browser/components/nsBrowserGlue.js#452

We could of course add one if we think that's the better solution. I personally am not a big fan of sprinkling debug/testing code everywhere but it also seems like it wouldn't hurt that much here.

Comment 6

[David Burns :automatedtester]

Comment on attachment 813685 [details] [diff] [review]
Suppress safe-mode dialog when starting in safe-mode

Review of attachment 813685 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry for the late review, looks good!

Comment 7

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/integration/fx-team/rev/7b19a91810cd

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/7b19a91810cd

Comment 9

[Jonathan Griffin (:jgriffin)]

https://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/d1b8d01de75f