923621 - mozbuild.frontend.reader.SandboxValidationError: Reference to a file that doesn't exist in CSRCS (icalderivedparameter.c) in calendar/libical/src/libical

Status: RESOLVED FIXED

(MailNews Core :: Build Config, defect)

Description

[Mark Banner (:standard8)]

Seen since some m-c bugs recently landed:

Traceback (most recent call last):
  File "./config.status", line 961, in <module>
    config_status(**args)
  File "/builds/slave/tb-c-cen-lx-ntly-0000000000000/build/mozilla/build/ConfigStatus.py", line 126, in config_status
    summary = backend.consume(definitions)
  File "/builds/slave/tb-c-cen-lx-ntly-0000000000000/build/mozilla/python/mozbuild/mozbuild/backend/base.py", line 188, in consume
    for obj in objs:
  File "/builds/slave/tb-c-cen-lx-ntly-0000000000000/build/mozilla/python/mozbuild/mozbuild/frontend/emitter.py", line 77, in emit
    for o in self.emit_from_sandbox(out):
  File "/builds/slave/tb-c-cen-lx-ntly-0000000000000/build/mozilla/python/mozbuild/mozbuild/frontend/emitter.py", line 134, in emit_from_sandbox
    % (symbol, src, sandbox['RELATIVEDIR']))
mozbuild.frontend.reader.SandboxValidationError: Reference to a file that doesn't exist in CSRCS (icalderivedparameter.c) in calendar/libical/src/libical
configure: error: /builds/slave/tb-c-cen-lx-ntly-0000000000000/build/mozilla/configure failed for mozilla

Comment 1

[Mark Banner (:standard8)]

The issue is in these files:

http://mxr.mozilla.org/comm-central/source/calendar/libical/src/libical/moz.build
http://mxr.mozilla.org/comm-central/source/calendar/libical/src/libical/Makefile.in

The Makefile.in is generating .c files from .c.in files, hence at generation time, these are listed in CSRCS but aren't available.

If I take them out of CSRCS, then the configure completes but link fails. What's the bit of magic I'm missing?

Comment 2

[Joshua Cranmer [:jcranmer]]

I believe we put them back in CSRCS in the Makefile.

Comment 3

[Mark Banner (:standard8)]

Thanks, attempted work around is here:

https://hg.mozilla.org/comm-central/rev/56a6ff586cda

(works for me locally).

Comment 4

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Yep, that's the correct fix for now. Thanks!

Comment 5

[Mark Banner (:standard8)]

Also had to fix windows:

https://hg.mozilla.org/comm-central/rev/66a1ea02542f