923646 - Conference Call Screen is missing call duration for an active call

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Victoria Gerchinhoren [:vicky]]

Attachment: Conference call. original vs screenshot

The main screen for Conference Call has a bad layout. Please see the attached screenshot analysis. Spacing, sizes are off and some information is missing.

Comment 1

[Preeti Raghunath(:Preeti)]

UX,

Please review. This seems to be an enhancement, please comment.

Comment 2

[Joe Cheng [:jcheng] (please needinfo)]

ni? ayman to confirm the spec

Comment 3

[jachen]

Ayman flagged so clearing general UX request.

Comment 4

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Looks like it's also missing the portrait images for the background?

Comment 5

[ayman maat :maat]

ni? to jacqueline to confirm specifications and behaviour of contact images in conference call

Comment 6

[Jacqueline Savory [:jsavory] UX]

The comments that Victoria has made regarding layout, spacing and missing info are all correct. Both the time of the call and conference participants are in the spec and should be displayed on the screen. 

The portrait images, however, were unable to make it into the spec and were therefore not included. The background in the current screenshot is correct.

Comment 7

[Preeti Raghunath(:Preeti)]

David,

Please reassign as this is a comms issue.

koi+ for better ux.

Comment 8

[Etienne Segonzac (:etienne)]

(In reply to Preeti Raghunath(:Preeti) from comment #7)
> koi+ for better ux.

Those are not trivial changes, and it's pretty late in the game for a "koi+ for better ux"...
Can we challenge this decision/get a stronger justification?

Comment 9

[Stephany Wilkes]

Sorry to be a pain, because I understand the 1.2 situation, but... This is not a trivial miss. This one is larger than the more "polish seeming" visual design issues that make up part of Victoria's feedback. This is not an enhancement, either, but a failure to implement to spec. 

While we could let the visual changes noted here slide (though they are small so that shouldn't be necessary), information about conference call participants is missing: the user cannot see who is on the call, which is a key part of a conference call feature. This is a missed partner requirement (Tef) and incorrect implementation.

Comment 10

[Etienne Segonzac (:etienne)]

(In reply to Stephany Wilkes from comment #9)
> the user cannot see who is on the call

This is incorrect, taping the disclosure icon shows the list of participant and lets you hang up on one of them.

Comment 11

[Preeti Raghunath(:Preeti)]

Tim,

Please move this forward per triage.

Comment 12

[Joe Cheng [:jcheng] (please needinfo)]

ni? should be for me to take on further discussion with comms team

Comment 13

[Joe Cheng [:jcheng] (please needinfo)]

ni? UX
let's break this down further and have UX feedback on them. Given the limited time we have for 1.2, we'd like to understand which part is unacceptable in terms of UX

1. call participants names not showing up in the call screen (but Etienne elaborated this further and there is a quick workaround)
2. call duration missing
3. icons not matching spec
4. call participants pictures not displayed (but what happens when there are 5 participants? each participant only gets a very small area displayed)

Thanks

Comment 14

[ayman maat :maat]

(In reply to Joe Cheng [:jcheng] from comment #13)
> ni? UX
> let's break this down further and have UX feedback on them. Given the
> limited time we have for 1.2, we'd like to understand which part is
> unacceptable in terms of UX

ok, for speed i am going to answer this

> 
> 1. call participants names not showing up in the call screen (but Etienne
> elaborated this further and there is a quick workaround)

This need to be fixed before going live

> 2. call duration missing

This needs to be fixed before going live

> 3. icons not matching spec

This can be fixed at a later date as the system is still perfectly usable even though the icons dont match

> 4. call participants pictures not displayed (but what happens when there are
> 5 participants? each participant only gets a very small area displayed)

This needs to be reviewed. Its not clear to me how these images will present themselves when: 

4.1) there are 3, 4 or 5 contacts on the call who all have images associated to them
4.2) there are 3, 4 or 5 contacts on the call of which only some have images associated to them

I am asking QA to run some tests for us to investigate and we will move forwards with point 4 based on their feedback

> 
> Thanks

ni? to me to follow up point 4

Comment 15

[Etienne Segonzac (:etienne)]

(In reply to ayman maat :maat from comment #14)
> > 
> > 1. call participants names not showing up in the call screen (but Etienne
> > elaborated this further and there is a quick workaround)
> 
> This need to be fixed before going live
> 

Again, I don't see how the missing one line, truncated, info text displaying at most 2 full names is a blocking issue.
The only reliable way to see all the participants on the conference is to tap the disclosure button and look at the list, and this is implemented.


> > 2. call duration missing
> 
> This needs to be fixed before going live

This is a missing feature (which was in the spec from the beginning but didn't got implemented in time).
It's very late in the game to implement it.

To be clear those 2 changes make perfect sense, we should do them, but I don't see how they're release-blockers.
So again my recommendation is to learn to work with the trains rather than encouraging late feature development.

Comment 16

[ayman maat :maat]

(In reply to Etienne Segonzac (:etienne) from comment #15)
> (In reply to ayman maat :maat from comment #14)
> > > 
> > > 1. call participants names not showing up in the call screen (but Etienne
> > > elaborated this further and there is a quick workaround)
> > 
> > This need to be fixed before going live
> > 
> 
> Again, I don't see how the missing one line, truncated, info text displaying
> at most 2 full names is a blocking issue.
> The only reliable way to see all the participants on the conference is to
> tap the disclosure button and look at the list, and this is implemented.
> 

Ok, thats a fair point, and i will concede that we should not block on this. I was probably a little trigger happy in my reply to this item.

> 
> > > 2. call duration missing
> > 
> > This needs to be fixed before going live
> 
> This is a missing feature (which was in the spec from the beginning but
> didn't got implemented in time).
> It's very late in the game to implement it.
> 

However, this is a blocker. Call duration and direction of call (incoming - outgoing) is an absolute must, and as you observe has been in the spec from the beginning. 

> To be clear those 2 changes make perfect sense, we should do them, but I
> don't see how they're release-blockers.
> So again my recommendation is to learn to work with the trains rather than
> encouraging late feature development.

I hear you on this. Perhaps we could discuss offline and we can see what we can do to help facilitate this alignment.

Comment 17

[ayman maat :maat]

Attachment: 923646 - visual test for contact images in conference calls.pdf

hi all

ok, big thanks to Isabel for running tests for us today so we can have clarity and move forwards with this.

(In reply to ayman maat :maat from comment #14)
> (In reply to Joe Cheng [:jcheng] from comment #13)
> > ni? UX
 
> > 4. call participants pictures not displayed (but what happens when there are
> > 5 participants? each participant only gets a very small area displayed)
> 
> This needs to be reviewed. Its not clear to me how these images will present
> themselves when: 
> 
> 4.1) there are 3, 4 or 5 contacts on the call who all have images associated
> to them
> 4.2) there are 3, 4 or 5 contacts on the call of which only some have images
> associated to them
> 
> I am asking QA to run some tests for us to investigate and we will move
> forwards with point 4 based on their feedback
> 
> > 
> > Thanks
> 
> ni? to me to follow up point 4

Isabel’s build was:

30/10 v1.2 build:
Gecko-f707339.
Gaia-a788ea1

What I asked Isabel to test was:

1) Create 5 contacts that all have images associated to them. Add them into the conference call one at a time and screenshot how the contact images are presenting themselves when there is 3, 4 and 5 contacts on the call (addresses 4.1 above)

2) Create 5 contacts, 3 of which have images associated to them. Add them into the conference call one at a time and screenshot how the contact images (or whatever place holder there is) are presenting themselves when there is 2, 3, 4 and 5 contacts on the call (addresses 4.2 above)

3) Create 5 contacts, none of which have images associated to them. Add them into the conference call one at a time and screenshot how the contact images (or whatever place holder there is) are presenting themselves when there is 2, 3, 4 and 5 contacts on the call (extends 4.2 above)

…Sadly we did not get past test 1.

Upon addition of contacts to the conference call the background image is changed to the image of the last contact added, and remains that way. (refer to attachment ‘923646 - visual test for contact images in conference calls’). Clearly this is not in line with the Visual Design proposition for how images associated to contacts should be displayed in a conference call and is quite misleading. 

However when i look at the visual design proposition, as stated, i have concerns about how contact images will be presented when 3+ contacts are on the conference call and when some of those contacts don’t have images. I don’t think it is going to scale gracefully or communicate well when the contacts do not have images associated to them.

In view of this I would suggest that we design a distinct ‘conference call’ background image that will be displayed when there is a conference taking place. I would not like to use the wall paper of the phone as this is what is used when there is a call to a single contact when the contact has no image associated to them.

At this point i am going to hand over to Jacqueline to drive the solution from here as she will be starting work in a bit (its morning now in Vancouver) and is overseeing the UX for the dialler. I have just accelerated the process for her due to time differences.

so, ni? to Jacqueline.

Comment 18

[Anthony Ricaud (:rik)]

About contact images as backgrounds, we were discussing it during development with Victoria via emails in August. Here's the final email of that thread, from Victoria:
> We discussed this conference call screen issues with the team, and hearing that it should be considered a nice to
> have (that meaning there's little time and certain complexity), we will push it for V1.3 so we properly specify and
> work around all the different scenarios.

And this doesn't seem something that Victoria emphasizes in attachment 813728 [details].

Comment 19

[ayman maat :maat]

(In reply to Anthony Ricaud (:rik) from comment #18)
> About contact images as backgrounds, we were discussing it during
> development with Victoria via emails in August. Here's the final email of
> that thread, from Victoria:
> > We discussed this conference call screen issues with the team, and hearing that it should be considered a nice to
> > have (that meaning there's little time and certain complexity), we will push it for V1.3 so we properly specify and
> > work around all the different scenarios.
> 
> And this doesn't seem something that Victoria emphasizes in attachment
> 813728 [details].

Hi Anthony

Ok i was not aware if any Visual discussions regarding the background image in conference calling, and if i had I would have called this out much much earlier on.

The current implementation whereby we display the image of the last contact added to the call poses a hefty usability issue. Imagery is important to influence perception. Its more influential than words. The display of the image of only one contact is reserved solely for 1:1 calls. This repetitive act of experiencing calling a contact 1:1 fossilises the users expectation that when they see a single contacts image full screen, they are dealing solely with that contact… Therefore to then display a single contacts image full screen during a conference call leads to confusion. For example when users ran though this they will initially think that they were dealing with only one contact, that the others were on hold, they will then think that the image was reflecting which contact was talking. In both instances they will be wrong in their perception and that will lead to erroneous behaviour. 

At the very least we need to remove that image of the contact during conference calling to avoid usability issues.

Due to our time constraints I will settle for removing the contact image during conference calling and display just the background wall paper with a view to postponing image management for future releases once a clear UX decision has been taken about it.

Comment 20

[Stephany Wilkes]

Picking this up in triage and following up with Wilfred to state (or reiterate, per Ayman's comment #14) exactly what is expected for shipping.

Comment 21

[Stephany Wilkes]

Flagging Wilfred to clarify the requirements about what can and cannot be missed. Wilfred, since we're both in SF right now perhaps we can talk through this one today. My understanding of what is needed and can slip matches Ayman's in comment #14, but clarity has been requested from Product.

Comment 22

[Kai-Chih Hu [:khu]]

Taipei triage result = suggest to have call duration, at least. And open other bugs for other issues. Let's use this bug to track call duration issue, how about it?

Comment 23

[Jason Smith [:jsmith]]

(In reply to Kevin Hu [:khu] from comment #22)
> Taipei triage result = suggest to have call duration, at least. And open
> other bugs for other issues. Let's use this bug to track call duration
> issue, how about it?

We might want to instead make this a meta bug, file separate issues for the specific issues in question in this bug, and nominate the ones that actually need to be fixed for 1.2.

Renoming - I think we need this broken up into actionable dependencies & have the blocking dependencies nominated to block.

Comment 24

[KM Lee [:rexboy] (inactivate after Sep. 22)]

We already have a metabug for all related polish things for bug 920526.

Per discussion in sprint planning, we are going to implement time duration on this bug.

Comment 25

[Jason Smith [:jsmith]]

(In reply to KM Lee [:rexboy] from comment #24)
> We already have a metabug for all related polish things for bug 920526.
> 
> Per discussion in sprint planning, we are going to implement time duration
> on this bug.

Okay. Let me change the title to indicate what we're targeting here in this bug then.

Comment 26

[Kai-Chih Hu [:khu]]

(In reply to Jason Smith [:jsmith] from comment #25)
> (In reply to KM Lee [:rexboy] from comment #24)
> > We already have a metabug for all related polish things for bug 920526.
> > 
> > Per discussion in sprint planning, we are going to implement time duration
> > on this bug.
> 
> Okay. Let me change the title to indicate what we're targeting here in this
> bug then.

Thank you, Jason!

Comment 27

[KM Lee [:rexboy] (inactivate after Sep. 22)]

We don't have call log for confernece call for now. All participants of conference call are logged separately. So I think I'll just follow that, showing the duration of conference call on the screen without logging it.

Comment 28

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Attachment: patch

Seems simple for this patch.
I just pull out the original ticker functionality to Utils for sharing between normal call and GroupCall. (And with Unit tests)

Hi Etienne, may you help review this patch?

Comment 29

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Attachment: Screenshot of proposed patch 1

Comment 30

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Attachment: Screenshot of proposed patch 2

Note that in this case we have no place to show duration because of the detail button.

Comment 31

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Attachment: Screenshot of proposed patch 1

Comment 32

[Stephany Wilkes]

Victoria and Ayman, please review the patch screenshots and let us know your thoughts. Thank you!

Comment 33

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 830765 [details]
patch

Sorry, a small update: Now resets photo to default when connected to group call.

Comment 34

[Etienne Segonzac (:etienne)]

Comment on attachment 830765 [details]
patch

First, kudos on adding tests for the timers with sinon!

My main issue is that I really don't want to add stuff to Utils because it's messy.

I think the best solution here is to add the following methods to the CallScreen:

|CallScreen.startDurationNode(node)|
|CallScreen.stopDurationNode(node)|

and put the ticker logic there, also those methods should add/remove the 'isTimer' css class.

Sounds good?

Comment 35

[Victoria Gerchinhoren [:vicky]]

Comment on attachment 830768 [details]
Screenshot of proposed patch 2

This is not following the recommendations made on the comparison attachment. It's not good to go from a visual/interacion POV. The call duration is missing, the conference call members are not shown and the arrow in the right is not good positioned.

Comment 36

[Victoria Gerchinhoren [:vicky]]

Comment on attachment 830769 [details]
Screenshot of proposed patch 1

timer: OK
Heading: conference participants are not shown and wrong position of the arrow.

Comment 37

[ayman maat :maat]

Comment on attachment 830768 [details]
Screenshot of proposed patch 2

Hi Stephany

I am looking at specification 'ConferenceCall_2013-07-25' which i am presuming is the last one published. I cannot find an exact match for this screen within the specifications, the closest I can find is screen E3 on page 12. 

I would say this screen is not there yet as it is missing call duration for the currently active call and this missing bit of information should block.

Comment 38

[ayman maat :maat]

Comment on attachment 830769 [details]
Screenshot of proposed patch 1

Hi Stephany

I am looking at specification 'ConferenceCall_2013-07-25'  

I would say this screen is not there yet as it is missing the direction of call icon that sits to the right of the call duration. This missing bit of information should block.

I would not block on the list of callers that is shown under the 'Group call (2)' header in the specification. The list of attendees should be displayed on this screen is not the full list of attendees and a complete list of attendees can be obtained by the user by selecting the arrow in the top right hand corner as demonstrated on page 12 of the specifications.

Comment 39

[ayman maat :maat]

removing ni? to me as i have given feedback on the attachments in comment 37 and comment 38.

Comment 40

[KM Lee [:rexboy] (inactivate after Sep. 22)]

(In reply to ayman maat :maat from comment #37)
> Comment on attachment 830768 [details]
> Screenshot of proposed patch 2
> 
> Hi Stephany
> 
> I am looking at specification 'ConferenceCall_2013-07-25' which i am
> presuming is the last one published. I cannot find an exact match for this
> screen within the specifications, the closest I can find is screen E3 on
> page 12. 
> 
> I would say this screen is not there yet as it is missing call duration for
> the currently active call and this missing bit of information should block.
The call duration is not showing here because the call in active is Conference
call, which contains a detail button blocking the area for showing duration.
So in case conference call is active, the duration shown when no other calls
present, like screenshot 2. This case is not included in spec so I think it
may be better not to block on this case. 

In case a regular call is in active, the duration would shown in proper. This
is implemented in bug 894270. Let me upload a screenshot for this.

Comment 41

[KM Lee [:rexboy] (inactivate after Sep. 22)]

sorry, I mean, like screenshot 1.

Comment 42

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Attachment: Screenshot of proposed patch 3

Comment 43

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Attachment: Screenshot of proposed patch 3

Comment 44

[KM Lee [:rexboy] (inactivate after Sep. 22)]

(In reply to ayman maat :maat from comment #38)
> I am looking at specification 'ConferenceCall_2013-07-25'  
> 
> I would say this screen is not there yet as it is missing the direction of
> call icon that sits to the right of the call duration. This missing bit of
> information should block.
I'm not pretty sure if we have a rule to determine the direction of conference
call... for example, if we joined one outgoing and one incoming call,
the direction is ambiguous. Any comments on this?
> 
> I would not block on the list of callers that is shown under the 'Group call
> (2)' header in the specification. The list of attendees should be displayed
> on this screen is not the full list of attendees and a complete list of
> attendees can be obtained by the user by selecting the arrow in the top
> right hand corner as demonstrated on page 12 of the specifications.

Comment 45

[Etienne Segonzac (:etienne)]

Can we please stay on point.
This bug is about adding the duration to conference calls, and it's a late blocker.
We lost enough time already discussing stuff randomly here instead of using properly filed bugs.

This patch successfully shows the duration when a conference call is ongoing:
https://bug923646.bugzilla.mozilla.org/attachment.cgi?id=830769

The only duration-related comment left is that when there is a conference call + another call ongoing (we display in 2 lines mode instead of 1 line mode) the duration isn't shown.
https://bug923646.bugzilla.mozilla.org/attachment.cgi?id=830768

But _nowhere_ in the spec do we see an active conference call displayed in 2 lines mode with a disclosure button and a duration.
So I think we should spec it and schedule it for a future release.

Rex is doing us all a solid adding this feature on such short notice, please reciprocate by focusing on the feature to get it through.

Comment 46

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 830765 [details]
patch

So, let’s pending
*direction of conference call,
*duration time of conference call under multi-call layout
*detailed contact info of conference call on group line
to later plan (file bugs?)
and focus on completing call duration for this bug.
Is it fine for us?

The right margin of detail button is easy to fix so I added
it in revised patch.

And, thanks for the reviewing Etienne.
I have refactored the patch to make ticker functions go under
CallScreen now. May you take a look again?

Comment 47

[Etienne Segonzac (:etienne)]

Comment on attachment 830765 [details]
patch

Getting there!

CallScreen.createTicker/stopTicker should directly take the dom node it's going to manipulate as a parameter.

Comment 48

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 830765 [details]
patch

Minor changes per discussion on github.

I'll squash all commits before landing. Thanks!

Ad this bug should have a few conflict with bug 920414 so I'll do some conflict resolving work before merging

Comment 49

[Etienne Segonzac (:etienne)]

Comment on attachment 830765 [details]
patch

All good, thanks for the hard work Rex!

We should probably land this before bug 920414 since this one is koi+.

Comment 50

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Merged on master:
https://github.com/mozilla-b2g/gaia/commit/df56d02d9040e3e31f574eb84a7c029600f7e011

Thanks for all the helping Etienne!


We can open bugs for items need to be planned (like the 3 items listed in comment 46) further.

Comment 51

[Jacqueline Savory [:jsavory] UX]

Hi Etienne and Rex,

Thank you for getting this feature in! 
I will create designs for the pending items as soon as possible, I think the priority of those items should be in the order in which Rex listed them:

- Direction of conference call.
- Duration time of conference call under multi-call layout.
- Detailed contact info on conference call on group line. 

Please cc me on the bugs that are opened for these issues and I will provide the redesigned specs for them.

Comment 52

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted df56d02d9040e3e31f574eb84a7c029600f7e011 to:
v1.2: 6a5636a9835848b1268806ee7a4c1c8620ad0c9b

Comment 53

[isabelrios]

Attachment: Conference call duration.png

Comment 54

[isabelrios]

Checked on 11/26 v1.2 build:
Gecko-6ac8a1e
Gaia-264c604

The duration of the call is shown now. Please see screenshot attached.

Ni? Victoria just to confirm it is shown fine before verifing the bug. Also to check whether follow ups are needed to cover the still missing icons according to the visuals attached. Thanks.

Comment 55

[Noemí Freire (:noemi)]

(In reply to Isabel Rios [:isabel_rios] from comment #54)
> Checked on 11/26 v1.2 build:
> Gecko-6ac8a1e
> Gaia-264c604
> 
> The duration of the call is shown now. Please see screenshot attached.
> 
Just adding that the right margin is also fixed. Notice that as requested by UX in comment 19 the contact image during conference calling has been removed and just displaying the background wall paper. 

So the pending bugs would be:
* UX decision about image management, is there any change needed?- ni to jaqueline to open a specific bug when the decision is made
* Call direction icon -ni to jaqueline to clarify which icon should be shown since multi conference call can be a mix of incoming and outgoing calls
* Detailed contact info of conference call on group line - Bug 943389

Thanks!

Comment 56

[isabelrios]

In case new bugs are needed, after receiving feedback on comment 55 new bugs would be open.
So far, this bug can be verified since the call duration is shown for conference call and the icon to see its details is correctly placed.

Verified with 11/26 v1.2 build:
Gecko-6ac8a1e
Gaia-264c604