Closed
Bug 923647
Opened 11 years ago
Closed 11 years ago
[Bluetooth] Replace GetDefaultAdapterPath by non-blocking code
Categories
(Firefox OS Graveyard :: Bluetooth, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: tzimmermann, Assigned: tzimmermann)
References
Details
Attachments
(1 file)
3.82 KB,
patch
|
echou
:
review+
|
Details | Diff | Splinter Review |
GetDefaultAdapterPath is the final piece of code that blocks on DBus. Replacing it with non-blocking code would allow us to remove a bunch of deprecated DBus code as well.
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → tzimmermann
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #819799 -
Flags: review?(echou)
Comment 2•11 years ago
|
||
Comment on attachment 819799 [details] [diff] [review] [01] Bug 923647: Replace GetDefaultAdapterAdapter by non-blocking implementation Review of attachment 819799 [details] [diff] [review]: ----------------------------------------------------------------- Looks good. Thanks for all your cleaning up effort, Thomas. See you next week in Taipei. ;)
Attachment #819799 -
Flags: review?(echou) → review+
Assignee | ||
Comment 3•11 years ago
|
||
Thanks for the review. I think this is finally the last blocking DBus call. https://hg.mozilla.org/integration/b2g-inbound/rev/f5b93f82ff3a https://tbpl.mozilla.org/?tree=B2g-Inbound&rev=f5b93f82ff3a > Looks good. Thanks for all your cleaning up effort, Thomas. See you next > week in Taipei. ;) Sadly, I had to cancel the work week because of a strong cold. So no visit to Taipei office for me next week. :(
Comment 4•11 years ago
|
||
What a pity :(
Comment 5•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/f5b93f82ff3a
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•