Closed Bug 923648 Opened 9 years ago Closed 9 years ago

Move tab-related images from /icons to /tabs like OS X on Windows and Linux.

Categories

(Thunderbird :: Theme, defect)

Product:
Thunderbird
Component:
Theme
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 27.0

People

(Reporter: jsbruner, Assigned: jsbruner)

References

Details

Attachments

(1 file, 3 obsolete files)

Patch.
23.96 KB, patch
jsbruner
: review+
Details | Diff | Splinter Review 
In /themes/osx/ we have a 'tabs' directory for all tab-related images, but on Windows and Linux we lack such a thing. This is just a little untidy and could be moved for consistency.
Attached patch Patch. (obsolete) — — Splinter Review 
This patch creates a tabs directory inside theme/windows and theme/linux and moves tab-related images inside it. Also switches code from theme that use to point at /icons to /tabs instead.
Assignee: nobody → josiah
Status: NEW → ASSIGNED
Attachment #814606 - Flags: review?(richard.marti)
Comment on attachment 814606 [details] [diff] [review]
Patch.

Review of attachment 814606 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good and is working (only tested on Win7). But I give r- because all moved files are deleted on old place and added on new place with this patch. This deletes the file history of them. Please can you use the rename instead?
Like:
diff --git a/mail/themes/linux/mail/icons/tabActiveEnd.svg b/mail/themes/linux/mail/tabs/tabActiveEnd.svg
rename from mail/themes/linux/mail/icons/tabActiveEnd.svg
rename to mail/themes/linux/mail/tabs/tabActiveEnd.svg

On Windows the tab.png is no more used, please remove it entirely.
Attachment #814606 - Flags: review?(richard.marti) → review-
Attached patch Patch. (obsolete) — — Splinter Review 
How's this?
Attachment #814606 - Attachment is obsolete: true
Attachment #815629 - Flags: review?(richard.marti)
Comment on attachment 815629 [details] [diff] [review]
Patch.

Review of attachment 815629 [details] [diff] [review]:
-----------------------------------------------------------------

Yeah, looks good r+
Attachment #815629 - Flags: review?(richard.marti) → review+
Attached patch Patch. (obsolete) — — Splinter Review 
Updated commit message.
Attachment #815629 - Attachment is obsolete: true
Attachment #818649 - Flags: review+
Attached patch Patch. — — Splinter Review 
... Uploaded the wrong patch.
Attachment #818649 - Attachment is obsolete: true
Attachment #818668 - Flags: review+
https://tbpl.mozilla.org/?tree=Thunderbird-Trunk&rev=32ffdedbff9a
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
> rename from mail/themes/windows/mail/icons/tabDragIndicator.png
> rename to mail/themes/windows/mail/tabs/tabDragIndicator.png

Since the images are now all in a /tabs/ directory you should shorten the names from e.g. "tabDragIndicator.png" to "dragIndicator.png" since the leading "tab" in the image names are now redundant.
Severity: trivial → normal
Flags: needinfo?(josiah)
Hardware: x86 → All
Target Milestone: --- → Thunderbird 27.0
Version: unspecified → Trunk
Depends on: 928361
(In reply to Philip Chee from comment #8)
> > rename from mail/themes/windows/mail/icons/tabDragIndicator.png
> > rename to mail/themes/windows/mail/tabs/tabDragIndicator.png
> 
> Since the images are now all in a /tabs/ directory you should shorten the
> names from e.g. "tabDragIndicator.png" to "dragIndicator.png" since the
> leading "tab" in the image names are now redundant.

Good point. Filed bug 928361 on that.
Flags: needinfo?(josiah)
You need to log in before you can comment on or make changes to this bug.