923653 - Layout of support contacts in settings is not displayed properly

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Albert [:albert]]

Attachment: screenshot

Firefox os v1.2 & master (unagi)
 
DEFECT DESCRIPTION:
 Wrong layout of settings support contacts.
 
REPRODUCING PROCEDURES:
 1. flash gaia with single variant resources (support contacts) in distribution dir.
 2. go to settings -> help
 
See attached screenshot

Comment 1

[Jason Smith [:jsmith]]

Can you provide test data you used to reproduce this bug?

Comment 2

[Jason Smith [:jsmith]]

Ended up seeing this bug while testing my reference customization, so that can be used to reproduce this bug as well:

https://github.com/mozilla/qa-testcase-data/tree/gh-pages/customization/reference

Comment 3

[Luke Chang [:lchang] (inactive)]

I can reproduce this bug.
But we need more information from UX team about how to fix its layout when the strings are too long.

Comment 4

[Neo Hsieh [:neo]]

Please show that wording in next line. 

Call support:
+886 2 XXXX-XXXX
+886 2 XXXX-XXXX

Comment 5

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Luke, since you already lay your hand on this bug, do you have bandwidth to do it?

Comment 6

[Luke Chang [:lchang] (inactive)]

Attachment: screenshot after patched

After discussing with UX team, we will change its design as the attachment.

Comment 7

[Luke Chang [:lchang] (inactive)]

Attachment: pull request (12929)

Arther, Could you please help review this simple patch? Thanks.

Comment 8

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 818820 [details]
pull request (12929)

Reassign to bugzilla mail.

Comment 9

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 818820 [details]
pull request (12929)

Cancel per offline discussion. Please help define the format of support.json and make corresponding changes in the code and wiki, thanks!

Comment 11

[Luke Chang [:lchang] (inactive)]

Comment on attachment 818820 [details]
pull request (12929)

Arthur, I've updated my patch and would like to ask you to review it again. Thanks.

For anyone else who may want to customize the support information, we have updated the format of "support.json" and you can find more details in the wiki. ( https://wiki.mozilla.org/B2G/MarketCustomizations#support )

Comment 12

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 818820 [details]
pull request (12929)

r=me. Thank you for the effort!

Comment 13

[Luke Chang [:lchang] (inactive)]

travis passed:
https://travis-ci.org/mozilla-b2g/gaia/builds/13023059

merged in gaia master:
https://github.com/mozilla-b2g/gaia/commit/0535641471428fd4410c150881f3635326b0642f

Arthur, Thanks!

Comment 14

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted 0535641471428fd4410c150881f3635326b0642f to:
v1.2: ac0fdef9da4aeeefe18441867dd810dee96e0d79

Comment 15

[John Hammink]

Fixed!  on the following build
Gaia:     606517ceafe0950c2b89822d5f13353743334f2c
Gecko:    http://hg.mozilla.org/releases/mozilla-aurora/rev/5eabd267ef04
BuildID   20131025004000
Version   26.0a2