923675 - Validation API endpoint should support application/x-www-form-urlencoded

Status: RESOLVED WORKSFORME

(Marketplace Graveyard :: API, defect, P3)

Description

[Christopher Van Wiemeersch [:cvan]]

I can never get an app to validate:

    % curl -X POST 'https://marketplace.firefox.com/api/v1/apps/validation/' -d 'manifest=http://app.testmanifest.com/manifest.webapp'
    {"error_message": {"__all__": ["Unsupported Content-Type header 'application/x-www-form-urlencoded'", "Unsupported Accept header '*/*'"]}}

Comment 1

[Rob Hudson [:robhudson]]

Works if you do this:
curl -X POST 'https://marketplace.firefox.com/api/v1/apps/validation/' -d '{"manifest": "http://app.testmanifest.com/manifest.webapp"}' -H 'Content-Type: application/json'

Comment 2

[Chuck Harmston [:chuck]]

Should we be supporting form-encoding at this endpoint?

Comment 3

[Christopher Van Wiemeersch [:cvan]]

(In reply to Chuck Harmston [:chuck] from comment #2)
> Should we be supporting form-encoding at this endpoint?

I would like for that to be accepted yes.

    $.post('https://marketplace.firefox.com/api/v1/apps/validation/', {'manifest': 'http://app.testmanifest.com/manifest.webapp'}

is nicer than

    $.ajax({
        type: 'post',
        url: 'https://marketplace.firefox.com/api/v1/apps/validation/',
        data: {manifest: 'http://app.testmanifest.com/manifest.webapp'},
        contentType: 'application/json',
        dataType: 'json',
    });

Comment 4

[Mathieu Pillard [:mat]]

We fixed that at some point (was that bug filed before the DRF switch ?)

curl -X POST 'https://marketplace.firefox.com/api/v1/apps/validation/' -d 'manifest=http://app.testmanifest.com/manifest.webapp'
{"id":"7e4a0d62f74d483a9e784ca906e266a5","processed":true,"valid":true,"validation":{...