Closed Bug 923686 Opened 11 years ago Closed 11 years ago

Refactor about:networking return values

Categories

(Core :: Networking, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla28

People

(Reporter: robertbindar, Assigned: robertbindar)

References

Details

Attachments

(1 file, 2 obsolete files)

We want the dashboard to return arrays like [{host: "host", port: 1234, ssl: true}, {...}, ...], it would make more sense this way and would be much easier to handle.
Attached patch refactor.patch (obsolete) — Splinter Review
thanks to Valentin for this patch
Assignee: nobody → robertbindar
Attachment #813770 - Flags: feedback?(mcmanus)
Blocks: 905178
Comment on attachment 813770 [details] [diff] [review]
refactor.patch

I didn't read the patch in detail - but the direction lgtm
Attachment #813770 - Flags: feedback?(mcmanus) → feedback+
Attached patch refactor.patch (obsolete) — Splinter Review
I've modified the tests too, here is a green try run:
https://tbpl.mozilla.org/?tree=Try&rev=7784400e89ba
Attachment #813770 - Attachment is obsolete: true
Attachment #819361 - Flags: review?(mcmanus)
Attachment #819361 - Flags: review?(mcmanus) → review?(valentin.gosu)
Attached patch refactor.patchSplinter Review
Sorry for the huge gap. Things have been crazy lately.
I updated Robert's patch with default values in the webidl, so the C++ code looks a little better now.
Attachment #819361 - Attachment is obsolete: true
Attachment #819361 - Flags: review?(valentin.gosu)
Attachment #8334175 - Flags: review?(mcmanus)
Attachment #8334175 - Flags: review?(mcmanus) → review?(hurley)
Attachment #8334175 - Flags: review?(hurley) → review+
https://hg.mozilla.org/mozilla-central/rev/6fbd2b0f0731
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: