Closed
Bug 923686
Opened 11 years ago
Closed 11 years ago
Refactor about:networking return values
Categories
(Core :: Networking, defect)
Core
Networking
Tracking
()
RESOLVED
FIXED
mozilla28
People
(Reporter: robertbindar, Assigned: robertbindar)
References
Details
Attachments
(1 file, 2 obsolete files)
28.43 KB,
patch
|
u408661
:
review+
|
Details | Diff | Splinter Review |
We want the dashboard to return arrays like [{host: "host", port: 1234, ssl: true}, {...}, ...], it would make more sense this way and would be much easier to handle.
Assignee | ||
Comment 1•11 years ago
|
||
thanks to Valentin for this patch
Assignee: nobody → robertbindar
Attachment #813770 -
Flags: feedback?(mcmanus)
Comment 2•11 years ago
|
||
Comment on attachment 813770 [details] [diff] [review] refactor.patch I didn't read the patch in detail - but the direction lgtm
Attachment #813770 -
Flags: feedback?(mcmanus) → feedback+
Assignee | ||
Comment 3•11 years ago
|
||
I've modified the tests too, here is a green try run: https://tbpl.mozilla.org/?tree=Try&rev=7784400e89ba
Attachment #813770 -
Attachment is obsolete: true
Attachment #819361 -
Flags: review?(mcmanus)
Updated•11 years ago
|
Attachment #819361 -
Flags: review?(mcmanus) → review?(valentin.gosu)
Sorry for the huge gap. Things have been crazy lately. I updated Robert's patch with default values in the webidl, so the C++ code looks a little better now.
Attachment #819361 -
Attachment is obsolete: true
Attachment #819361 -
Flags: review?(valentin.gosu)
Attachment #8334175 -
Flags: review?(mcmanus)
Updated•11 years ago
|
Attachment #8334175 -
Flags: review?(mcmanus) → review?(hurley)
Attachment #8334175 -
Flags: review?(hurley) → review+
Thanks
Keywords: checkin-needed
Comment 7•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/6fbd2b0f0731
Flags: in-testsuite+
Keywords: checkin-needed
Attachment #819361 -
Flags: review?(valentin.gosu)
Comment 8•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/6fbd2b0f0731
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
You need to log in
before you can comment on or make changes to this bug.
Description
•