Closed Bug 923693 Opened 6 years ago Closed 6 years ago

Distinguish different kinds of object state changes in type information

Categories

(Core :: JavaScript Engine, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla27

People

(Reporter: bhackett, Assigned: bhackett)

References

Details

Attachments

(1 file)

Attached patch patchSplinter Review
The mechanism currently used for triggering invalidations generically on changes to the state of an object or type object is not compatible with bug 785905.  When constraints are attached to the type information after compilation finishes, the state may already have changed with respect to the original assumption in a way the constraint can't detect.  Separating out the different kinds of ways that compilation relies on non-flag non-type information in an object, and specifying that assumption explicitly, allows this to be fixed.
Attachment #813775 - Flags: review?(jdemooij)
Attachment #813775 - Flags: review?(jdemooij) → review+
https://hg.mozilla.org/mozilla-central/rev/f868d4f8f27e
Assignee: nobody → bhackett1024
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
You need to log in before you can comment on or make changes to this bug.