windows should ignore closed windows

RESOLVED FIXED

Status

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mossop, Assigned: mossop)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
The window enumerator returns windows that have already been closed sometimes, these should probably be ignored. See the comment at http://hg.mozilla.org/mozilla-central/diff/da5496557024/addon-sdk/source/lib/sdk/window/utils.js
(Assignee)

Updated

5 years ago
Assignee: nobody → dtownsend+bugmail
(Assignee)

Comment 1

5 years ago
Created attachment 814629 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/1261

Pointer to Github pull-request
(Assignee)

Updated

5 years ago
Attachment #814629 - Flags: review?(evold)
Comment on attachment 814629 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/1261

Just mentioned a minor issue in the pull request.
Attachment #814629 - Flags: review?(evold) → review-
(Assignee)

Comment 3

5 years ago
Comment on attachment 814629 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/1261

Updated
Attachment #814629 - Flags: review- → review?(evold)
Attachment #814629 - Flags: review?(evold) → review+

Comment 4

5 years ago
Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/a9d4a94dcd8ccefcc9b4ae164f1ec375e3aa53b9
Bug 923715: Ignore closed windows in the windows iterator.

https://github.com/mozilla/addon-sdk/commit/53503fcf6df8364e1dda9adf7595c74026015f2a
Merge pull request #1261 from Mossop/bug923715

Bug 923715: Ignore closed windows in the windows iterator. r=erikvold
(Assignee)

Updated

5 years ago
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.