If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

AudioChannelService should not send notifications and/or use callbacks when XPCOM is shutting down.

RESOLVED FIXED in mozilla27

Status

()

Core
DOM
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: baku, Assigned: baku)

Tracking

Trunk
mozilla27
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Updated

4 years ago
Blocks: 874508
(Assignee)

Comment 1

4 years ago
Created attachment 813840 [details] [diff] [review]
service.patch
Attachment #813840 - Flags: review?(ehsan)
I see this blocks a blocker - does this need to be koi+?
Could this lead to a crash?  A la bug 923173?
Comment on attachment 813840 [details] [diff] [review]
service.patch

Review of attachment 813840 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/audiochannel/AudioChannelService.h
@@ +178,5 @@
>    uint64_t mTimerChildID;
>  
>    uint64_t mDefChannelChildID;
>  
> +  bool mDisabled;

Nit: please move the booleans together for better packing.
Attachment #813840 - Flags: review?(ehsan) → review+
(Assignee)

Comment 5

4 years ago
 https://hg.mozilla.org/integration/mozilla-inbound/rev/67595062eee3
https://hg.mozilla.org/mozilla-central/rev/67595062eee3
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
You need to log in before you can comment on or make changes to this bug.