Status

Firefox OS
Gaia::Everything.me
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: Evyatar 'Tron' Amitay (everything.me), Assigned: Evyatar 'Tron' Amitay (everything.me))

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

In certain cases, new collections can't be added to the home screen. This happens because a bug in the code causing app icons from the cache to not appear properly.
Created attachment 813862 [details]
Patch - redirect to github PR

Previously if an icon was null, the code simply failed trying to draw "null" into the canvas.

Now if one if the icons is null or undefined, the icon will adjust itself to use a 2-apps or 1-app template.
Attachment #813862 - Flags: review?(crdlc)
Attachment #813862 - Flags: review?(amirn)

Updated

4 years ago
Blocks: 923901

Updated

4 years ago
Attachment #813862 - Flags: review?(amirn) → review+
Attachment #813862 - Flags: review?(crdlc) → review?(ran)
Comment on attachment 813862 [details]
Patch - redirect to github PR

Works well
Attachment #813862 - Flags: review?(ran) → review+
merged into master
5c4122723af26bf6282199251124b0540b0c374c

https://github.com/mozilla-b2g/gaia/commit/5c4122723af26bf6282199251124b0540b0c374c
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED

Comment 4

4 years ago
Created attachment 8342848 [details]
Missing icons

Is this the bug I'm seeing  on this screen capture or a different one?

This is from an up to date Leon.
Flags: needinfo?(evyatar)
This looks like the same issue - can you write the STR here?
Flags: needinfo?(evyatar)
You need to log in before you can comment on or make changes to this bug.