Closed Bug 923810 Opened 7 years ago Closed 7 years ago

Defect - Progress bar does not update correctly when switching tabs

Categories

(Firefox for Metro Graveyard :: Browser, defect, P2)

All
Windows 8.1
defect

Tracking

(Not tracked)

VERIFIED FIXED
Firefox 27

People

(Reporter: mbrubeck, Assigned: mbrubeck)

References

Details

(Whiteboard: feature=defect c=tbd u=tbd p=1 )

Attachments

(1 file)

Attached patch patchSplinter Review
Steps to reproduce:
1) Open two tabs in Metro Firefox
2) Begin loading a slow-loading web page in one tab
3) Switch to the other tab

Expected results: The progress bar disappears when you switch to the non-loading tab, and reappears if you switch back to the loading tab.

Actual results: The progress bar does not change as you switch tabs.

This patch keeps track of progress separately for each tab, and updates the UI when the selected tab changes.
Attachment #813868 - Flags: review?(jmathies)
Flags: in-testsuite?
Point value for this defect?
Blocks: metrov1it16
Flags: needinfo?(mbrubeck)
Priority: -- → P2
QA Contact: jbecerra
Whiteboard: feature=defect c=testing u=developer p=0
Whiteboard: feature=defect c=testing u=developer p=0 → feature=defect c=tbd u=tbd p=0
p=1
Flags: needinfo?(mbrubeck)
Whiteboard: feature=defect c=tbd u=tbd p=0 → feature=defect c=tbd u=tbd p=1
Comment on attachment 813868 [details] [diff] [review]
patch

Review of attachment 813868 [details] [diff] [review]:
-----------------------------------------------------------------

tested on a few bugzilla pages over strained wireless, works as expected.

::: browser/metro/base/content/WebProgress.js
@@ +155,3 @@
>        return;
>  
> +    aTab._progressActive = true;

maybe make these a getter?
Attachment #813868 - Flags: review?(jmathies) → review+
https://hg.mozilla.org/integration/fx-team/rev/775f94fe7a01
Whiteboard: feature=defect c=tbd u=tbd p=1 → feature=defect c=tbd u=tbd p=1 [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/775f94fe7a01
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: feature=defect c=tbd u=tbd p=1 [fixed-in-fx-team] → feature=defect c=tbd u=tbd p=1
Target Milestone: --- → Firefox 27
Mozilla/5.0 (Windows NT 6.2; WOW64; rv:27.0) Gecko/20100101 Firefox/27.0
Mozilla/5.0 (Windows NT 6.2; rv:27.0) Gecko/20100101 Firefox/27.0

Verified on the latest nightly (Build ID: 20131016030202).
The progress bar disappears when you switch to the non-loading tab, and reappears if you switch back to the loading tab.
Status: RESOLVED → VERIFIED
Blocks: 934496
OS: Windows 8 Metro → Windows 8.1
You need to log in before you can comment on or make changes to this bug.