923810 - Defect - Progress bar does not update correctly when switching tabs

Status: VERIFIED FIXED

(Firefox for Metro Graveyard :: Browser, defect, P2)

Description

[Matt Brubeck (:mbrubeck)]

Attachment: patch

Steps to reproduce:
1) Open two tabs in Metro Firefox
2) Begin loading a slow-loading web page in one tab
3) Switch to the other tab

Expected results: The progress bar disappears when you switch to the non-loading tab, and reappears if you switch back to the loading tab.

Actual results: The progress bar does not change as you switch tabs.

This patch keeps track of progress separately for each tab, and updates the UI when the selected tab changes.

Comment 1

[Marco Mucci [:MarcoM]]

Point value for this defect?

Comment 2

[Matt Brubeck (:mbrubeck)]

p=1

Comment 3

[Jim Mathies [:jimm]]

Comment on attachment 813868 [details] [diff] [review]
patch

Review of attachment 813868 [details] [diff] [review]:
-----------------------------------------------------------------

tested on a few bugzilla pages over strained wireless, works as expected.

::: browser/metro/base/content/WebProgress.js
@@ +155,3 @@
>        return;
>  
> +    aTab._progressActive = true;

maybe make these a getter?

Comment 4

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/integration/fx-team/rev/775f94fe7a01

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/775f94fe7a01

Comment 6

[Cornel Ionce [:noni] [Hubs QA]]

Mozilla/5.0 (Windows NT 6.2; WOW64; rv:27.0) Gecko/20100101 Firefox/27.0
Mozilla/5.0 (Windows NT 6.2; rv:27.0) Gecko/20100101 Firefox/27.0

Verified on the latest nightly (Build ID: 20131016030202).
The progress bar disappears when you switch to the non-loading tab, and reappears if you switch back to the loading tab.