923848 - Remove redundant mp3 file format check

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Sotaro Ikeda [:sotaro]]

+++ This bug was initially created as a clone of Bug #922334 +++

By Bug 922334, mp3 file format check is added to OmxDecoder.
So following mp3 file check became reduncant and can remove it.

-----------------------------------------
bool OmxDecoder::TryLoad() {
// snip
    if (meta->findCString(kKeyMIMEType, &audioMime) && !strcasecmp(audioMime, AUDIO_MP3)) {
      // Feed MP3 parser with cached data. Local files will be fully
      // cached already, network streams will update with sucessive
      // calls to NotifyDataArrived.
      if (ProcessCachedData(0, true)) {
        durationUs = mMP3FrameParser.GetDuration();
        if (durationUs > totalDurationUs) {
          totalDurationUs = durationUs;
        }
      }
    }

Comment 1

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Reuse mp3 file format check result

Reuse the mp3 format info got from extractor.

Comment 2

[cajbir (:cajbir)]

Comment on attachment 814471 [details] [diff] [review]
patch - Reuse mp3 file format check result

Thomas Zimmermann originally added this code so I'd like feedback from them before I review it. Re-ask for review when Thomas has given feedback and it's been addressed, if anything needs addressing.

Comment 3

[cajbir (:cajbir)]

Comment on attachment 814471 [details] [diff] [review]
patch - Reuse mp3 file format check result

r+ from me based on :tzimmermann's feedback.

Comment 4

[Sotaro Ikeda [:sotaro]]

Attachment: patch v2 - Reuse mp3 file format check result

Committable patch. Carry 'chris.double: review+'.

Comment 5

[Sotaro Ikeda [:sotaro]]

https://tbpl.mozilla.org/?tree=Try&rev=0db5c54fbce0

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/843312df7677

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/843312df7677