Remove redundant mp3 file format check

RESOLVED FIXED in mozilla27

Status

()

defect
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: sotaro, Assigned: sotaro)

Tracking

Trunk
mozilla27
ARM
Gonk (Firefox OS)
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

+++ This bug was initially created as a clone of Bug #922334 +++

By Bug 922334, mp3 file format check is added to OmxDecoder.
So following mp3 file check became reduncant and can remove it.

-----------------------------------------
bool OmxDecoder::TryLoad() {
// snip
    if (meta->findCString(kKeyMIMEType, &audioMime) && !strcasecmp(audioMime, AUDIO_MP3)) {
      // Feed MP3 parser with cached data. Local files will be fully
      // cached already, network streams will update with sucessive
      // calls to NotifyDataArrived.
      if (ProcessCachedData(0, true)) {
        durationUs = mMP3FrameParser.GetDuration();
        if (durationUs > totalDurationUs) {
          totalDurationUs = durationUs;
        }
      }
    }
Assignee: nobody → sotaro.ikeda.g
Severity: critical → normal
Reuse the mp3 format info got from extractor.
Attachment #814471 - Flags: review?(chris.double)
Comment on attachment 814471 [details] [diff] [review]
patch - Reuse mp3 file format check result

Thomas Zimmermann originally added this code so I'd like feedback from them before I review it. Re-ask for review when Thomas has given feedback and it's been addressed, if anything needs addressing.
Attachment #814471 - Flags: review?(chris.double) → feedback?(tzimmermann)
Attachment #814471 - Flags: feedback?(tzimmermann) → feedback+
Attachment #814471 - Flags: review?(chris.double)
Comment on attachment 814471 [details] [diff] [review]
patch - Reuse mp3 file format check result

r+ from me based on :tzimmermann's feedback.
Attachment #814471 - Flags: review?(chris.double) → review+
Committable patch. Carry 'chris.double: review+'.
Attachment #814471 - Attachment is obsolete: true
Attachment #816287 - Flags: review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/843312df7677
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
You need to log in before you can comment on or make changes to this bug.