Closed
Bug 923857
Opened 11 years ago
Closed 11 years ago
Australis: Customize Mode wrap/unwrap handlers fire during reset's buildArea calls
Categories
(Firefox :: Toolbars and Customization, defect)
Tracking
()
RESOLVED
FIXED
Firefox 28
People
(Reporter: Gijs, Assigned: Gijs)
References
(Blocks 1 open bug)
Details
(Whiteboard: [Australis:M9][Australis:P1])
Attachments
(1 file)
5.98 KB,
patch
|
jaws
:
review+
|
Details | Diff | Splinter Review |
STR: 1. Start with a clean/defaults-restored profile 2. Open customize mode 3. Drag the developer tools button between the search bar and the star button, on the navbar. 4. Drag the search box to the palette 5. click restore defaults ER: Defaults are restored AR: Default prefs are restored, but the devtools button stays in the navbar. :-\ Note also that the restore button is now disabled. For added fun, drag the button to the panel and back to the navbar. Click Restore Defaults again. The search box now disappears. Something is very very very wrong. :-( (after a restart, it goes away) (P1/M9 because this is pretty amazingly broken... )
Assignee | ||
Comment 1•11 years ago
|
||
So the issue is that buildArea does insertions which make our customize code wrap things, which then confuses stuff again later on. Not great. This is a test for this situation, and a pretty simple fix.
Attachment #813932 -
Flags: review?(jaws)
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Assignee | ||
Updated•11 years ago
|
Summary: Australis: Customize Mode gets confused about the developer button (API-provided widgets?) sometimes → Australis: Customize Mode wrap/unwrap handlers fire during reset's buildArea calls
Comment 2•11 years ago
|
||
Comment on attachment 813932 [details] [diff] [review] while resetting, shouldn't wrap/unwrap based on notifications, Review of attachment 813932 [details] [diff] [review]: ----------------------------------------------------------------- Thank you for the quick fix!
Attachment #813932 -
Flags: review?(jaws) → review+
Assignee | ||
Comment 3•11 years ago
|
||
https://hg.mozilla.org/projects/ux/rev/ac9d4c0c34bd
Whiteboard: [Australis:M9][Australis:P1] → [Australis:M9][Australis:P1][fixed-in-ux]
Assignee | ||
Comment 4•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/ac9d4c0c34bd
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [Australis:M9][Australis:P1][fixed-in-ux] → [Australis:M9][Australis:P1]
Target Milestone: --- → Firefox 28
You need to log in
before you can comment on or make changes to this bug.
Description
•