Closed Bug 923871 Opened 11 years ago Closed 11 years ago

[Contacts] Do not load import_sim_contacts.js for contacts list display

Categories

(Firefox OS Graveyard :: Gaia::Contacts, defect, P1)

ARM
Gonk (Firefox OS)
defect

Tracking

(blocking-b2g:koi+, b2g-v1.2 fixed)

RESOLVED FIXED
1.2 C3(Oct25)
blocking-b2g koi+
Tracking Status
b2g-v1.2 --- fixed

People

(Reporter: kgrandon, Assigned: kgrandon)

References

Details

(Keywords: perf, Whiteboard: [c= p=2 s= u=1.2])

Attachments

(1 file)

We currently lazy load sim_contacts.js, but it is in the path of contacts list display. When we use this we show a progress bar, and as we have a higher expectation of slowdown so we can wait until that point to load this. Note: This should not have any impact on the datazilla numbers, but we should get to the first ready-to-use state faster.
Attached file Github pull request
Attachment #813910 - Flags: review?(francisco.jordano)
OS: Mac OS X → Gonk (Firefox OS)
Hardware: x86 → ARM
Whiteboard: [c= p=2 s= u=] → [c= p=2 s=2013.09.20 u=]
Whiteboard: [c= p=2 s=2013.09.20 u=] → [c= p=2 s=2013.10.18 u=]
Comment on attachment 813910 [details] Github pull request Looking perfect to me, tried on the phone and working pretty nice. Just left a comment in github regarding move the load of different libraries to the library loader in Contacts. Cheers! F.
Attachment #813910 - Flags: review?(francisco.jordano) → review+
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Blocks a blocker.
blocking-b2g: --- → koi?
blocking-b2g: koi? → koi+
Priority: -- → P1
Whiteboard: [c= p=2 s=2013.10.18 u=] → [c= p=2 s=2013.10.18 u=1.2]
Target Milestone: --- → 1.2 C3(Oct25)
Whiteboard: [c= p=2 s=2013.10.18 u=1.2] → [c= p=2 s= u=1.2]
Uplifted a97b97c77743c56978859770e63007c64bf70aa6 to: v1.2: 0f90dc9a69401cde11044439066cb927ef3f7c36
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: