Closed Bug 923873 Opened 11 years ago Closed 11 years ago

[Contacts] Do not load overlay.js for list display

Categories

(Firefox OS Graveyard :: Gaia::Contacts, defect, P1)

Product:
Firefox OS Graveyard
Component:
Gaia::Contacts
Platform:
ARM
Gonk (Firefox OS)
Type:
defect

Tracking

(blocking-b2g:koi+, b2g-v1.2 fixed)

Status:
RESOLVED FIXED
Milestone:
1.2 C3(Oct25)
Project Flags:
blocking-b2g koi+
Tracking Flags:
Tracking Status
b2g-v1.2 --- fixed

People

(Reporter: kgrandon, Assigned: kgrandon)

References

Details

(Keywords: perf, Whiteboard: [c= p=1 s= u=1.2])

Attachments

(1 file)

Github pull request
222 bytes, text/html
arcturus
: review+
Details 
I am silly. I did a bunch of work to be able to lazy load overlay.js, but we still load this file before contacts list display.

Note: This should not have any impact on the datazilla numbers, but we should get to the first ready-to-use state faster.
Seems to have been a rebasing issue.
Depends on: 915018
Attached file Github pull request — 

        Attachment #813912 -
        Flags: review?(francisco.jordano)

    
  
Whiteboard: [c= p=1 s=2013.09.20 u=] → [c= p=1 s=2013.10.04 u=]

    
    

    
  
Oops, should this be 10/18?
Whiteboard: [c= p=1 s=2013.10.04 u=] → [c= p=1 s=2013.10.18 u=]

    
    

    
  
This is blocking a koi+ so nominating as koi.
blocking-b2g: --- → koi?

        Attachment #813912 -
        Flags: review?(francisco.jordano) → review+

    
    

    
  
Landed:

https://github.com/mozilla-b2g/gaia/commit/a33085ab19a7201ee6abd593f8987b6c17cec629
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED

    
  
blocking-b2g: koi? → koi+
Priority: -- → P1
Whiteboard: [c= p=1 s=2013.10.18 u=] → [c= p=1 s=2013.10.18 u=1.2]
Target Milestone: --- → 1.2 C3(Oct25)

    
  
Whiteboard: [c= p=1 s=2013.10.18 u=1.2] → [c= p=1 s= u=1.2]

    
    

    
  
Uplifted a33085ab19a7201ee6abd593f8987b6c17cec629 to:
v1.2: a52d6bf6f97566b94517ecff94045793b7b74f8f

          status-b2g-v1.2:
          --- → fixed

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: