Keyboard should hide after tapping outside of Find In Page bar

NEW
Assigned to

Status

()

5 years ago
4 years ago

People

(Reporter: rnewman, Assigned: darkowlzz, Mentored)

Tracking

Trunk
All
Android
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [lang=java])

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
It hides when you hit the next/prev buttons, but not when you focus the page. This handily allows me to navigate the page by tapping Space, but really isn't desirable otherwise.

Comment 1

5 years ago
I think this could make a good mentor bug. Sriram, I feel like you would know how to fix this, so would you want to be a mentor for this bug?
Flags: needinfo?(sriram)
I could mentor this.
Flags: needinfo?(sriram)
Whiteboard: [mentor=sriram]

Comment 3

5 years ago
(In reply to Sriram Ramasubramanian [:sriram] from comment #2)
> I could mentor this.

Awesome! Thanks!
Whiteboard: [mentor=sriram] → [mentor=sriram][lang=java]

Comment 4

5 years ago
(In reply to Sriram Ramasubramanian [:sriram] from comment #2)
> I could mentor this.

Hi, I'm a new developer and I would like to know if this may be a good bug to start on mozilla.
Thanks.
Flags: needinfo?(sriram)
I know someone was trying to work on it by asking questions in IRC. I don't see him now. If he doesn't want to take it, you could work on this.
Flags: needinfo?(sriram)
(Assignee)

Comment 6

5 years ago
Hi,
I am the one who is working on it. It's the first fennec bug I am working on :)
Assignee: nobody → indiasuny000
(Assignee)

Comment 7

5 years ago
Created attachment 818660 [details] [diff] [review]
Added an onFocusChange listener to mFindText which takes care of the SoftInput

This patch seems to work.
Please see if this is how it should be.

Also, do I have to write a test for this?
Attachment #818660 - Flags: feedback?(sriram)
Comment on attachment 818660 [details] [diff] [review]
Added an onFocusChange listener to mFindText which takes care of the SoftInput

This feels right. This would hide the IME when the focus moves from the text to the up/down arrow.
Attachment #818660 - Flags: feedback?(sriram) → feedback+
(Assignee)

Updated

5 years ago
Attachment #818660 - Flags: feedback+ → feedback?(margaret.leibovic)

Comment 9

5 years ago
(In reply to Sunny [:darkowlzz] from comment #7)

> Also, do I have to write a test for this?

Not strictly required, but it would be greatly appreciated! You could probably add something to this existing test:
http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/tests/testFindInPage.java.in

Comment 10

5 years ago
Comment on attachment 818660 [details] [diff] [review]
Added an onFocusChange listener to mFindText which takes care of the SoftInput

Review of attachment 818660 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good to me.
Attachment #818660 - Flags: feedback?(margaret.leibovic) → feedback+
Status: NEW → ASSIGNED
(Assignee)

Comment 11

5 years ago
I was trying to write test for the above fix, but got stuck with detecting the visibility of the virtual keyboard on the screen. How do I check for it's visibility on the screen?
Status: ASSIGNED → NEW
Mentor: sriram.mozilla
Whiteboard: [mentor=sriram][lang=java] → [lang=java]
You need to log in before you can comment on or make changes to this bug.