923885 - Keyboard should hide after tapping outside of Find In Page bar

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: General, defect)

Description

[Richard Newman [:rnewman]]

It hides when you hit the next/prev buttons, but not when you focus the page. This handily allows me to navigate the page by tapping Space, but really isn't desirable otherwise.

Comment 1

[:Margaret Leibovic]

I think this could make a good mentor bug. Sriram, I feel like you would know how to fix this, so would you want to be a mentor for this bug?

Comment 2

[Sriram Ramasubramanian [:sriram]]

I could mentor this.

Comment 3

[:Margaret Leibovic]

(In reply to Sriram Ramasubramanian [:sriram] from comment #2)
> I could mentor this.

Awesome! Thanks!

Comment 4

[Anderson]

(In reply to Sriram Ramasubramanian [:sriram] from comment #2)
> I could mentor this.

Hi, I'm a new developer and I would like to know if this may be a good bug to start on mozilla.
Thanks.

Comment 5

[Sriram Ramasubramanian [:sriram]]

I know someone was trying to work on it by asking questions in IRC. I don't see him now. If he doesn't want to take it, you could work on this.

Comment 6

[Sunny [:darkowlzz]]

Hi,
I am the one who is working on it. It's the first fennec bug I am working on :)

Comment 7

[Sunny [:darkowlzz]]

Attachment: Added an onFocusChange listener to mFindText which takes care of the SoftInput

This patch seems to work.
Please see if this is how it should be.

Also, do I have to write a test for this?

Comment 8

[Sriram Ramasubramanian [:sriram]]

Comment on attachment 818660 [details] [diff] [review]
Added an onFocusChange listener to mFindText which takes care of the SoftInput

This feels right. This would hide the IME when the focus moves from the text to the up/down arrow.

Comment 9

[:Margaret Leibovic]

(In reply to Sunny [:darkowlzz] from comment #7)

> Also, do I have to write a test for this?

Not strictly required, but it would be greatly appreciated! You could probably add something to this existing test:
http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/tests/testFindInPage.java.in

Comment 10

[:Margaret Leibovic]

Comment on attachment 818660 [details] [diff] [review]
Added an onFocusChange listener to mFindText which takes care of the SoftInput

Review of attachment 818660 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good to me.

Comment 11

[Sunny [:darkowlzz]]

I was trying to write test for the above fix, but got stuck with detecting the visibility of the virtual keyboard on the screen. How do I check for it's visibility on the screen?

Comment 12

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.