Closed Bug 923886 Opened 7 years ago Closed 7 years ago

Remove the Assertions.h #include from Char16.h

Categories

(Core :: MFBT, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla27

People

(Reporter: ehsan, Assigned: ehsan)

Details

Attachments

(1 file)

Attached patch Patch (v1)Splinter Review
https://tbpl.mozilla.org/?tree=Try&rev=fdb325fc650e

This used to be necessary for MOZ_STATIC_ASSERT.
Attachment #813920 - Flags: review?(jwalden+bmo)
Assignee: nobody → ehsan
Comment on attachment 813920 [details] [diff] [review]
Patch (v1)

Review of attachment 813920 [details] [diff] [review]:
-----------------------------------------------------------------

::: mfbt/Char16.h
@@ -9,5 @@
>  #ifndef mozilla_Char16_h
>  #define mozilla_Char16_h
>  
> -#include "mozilla/Assertions.h"
> -

r-, you should have removed the blank line *above* the #include, not the one below it.
Attachment #813920 - Flags: review?(jwalden+bmo) → review+
https://hg.mozilla.org/mozilla-central/rev/12e0095aeef9
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
You need to log in before you can comment on or make changes to this bug.