923910 - Use https URLs in post_upload.ini so job build properties reference the https log/binary locations

Status: RESOLVED WORKSFORME

(Release Engineering :: General, defect)

Description

[Eric Rescorla (:ekr)]

The build directory URLs in tbpl (when you click "go to build directory") are http:// URLs.

The build directories are served over https already. It's just the link that needs to be changed.

Comment 1

[Ed Morley [:emorley]]

The URL used for this link comes directly from the log URL specified in the buildbot data exports used by TBPL for non-Try [1] (the UI just chops off the log filename to obtain the directory location) and for Try is specified in Config.js [2].

The latter is already using https, the former would be best changed in buildbot, since it's used by a few other things downstream in addition to TBPL.

TBPL should copy fine with the switch to https, since the backend sanity checking only checks the hostname used [3].

Afaict, the buildbot side needs changing in post_upload.ini, which is sadly in a non-public SVN repo. See bug 816365 for an example of changing the ftp log URLs.


[1] https://hg.mozilla.org/webtools/tbpl/file/f850901cb016/js/UserInterface.js#l1460
[2] https://hg.mozilla.org/webtools/tbpl/file/f850901cb016/js/Config.js#l56
[3] https://hg.mozilla.org/webtools/tbpl/file/f850901cb016/php/inc/RawGzLogDownloader.php#l19

Comment 2

[Ed Morley [:emorley]]

(In reply to Ed Morley (Away until 9th Oct) [:edmorley UTC+1] from comment #1)
> See bug 816365 for an example of changing the ftp log URLs.

Sorry I meant bug 815124.

Comment 3

[Nick Thomas [:nthomas] (UTC+12)]

Please note that modifying the post_upload config will also result in all test traffic switching to using https. Since that's a lot of traffic (the majority on ftp.m.o??) we should run this by IT, probably jakem first.

Comment 4

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Is bug 960571 leading to progress here?

Comment 5

[Chris AtLee [:catlee]]

Is this something we can fix up in the new post_upload?

Comment 6

[Nick Thomas [:nthomas] (UTC+12)]

See also https://bugzilla.mozilla.org/show_bug.cgi?id=1225303. There's a class of maybe-failures of the form
* jobs publish bits to archive.m.o, which starts returning with https prefix
* the job adds that as a buildbot property
* that's passed on to downstream jobs, which may not be set up to handle https

Comment 7

[Jeremy Orem [:oremj]]

(In reply to Chris AtLee [:catlee] from comment #5)
> Is this something we can fix up in the new post_upload?

Does this just have to do with the URL on stderr?