923989 - 404 on "Mark this as solved" in question response emails

Status: RESOLVED WORKSFORME

(support.mozilla.org :: General, defect, P1)

Description

[Michael Cooper [:mythmon]]

As a test, I just asked and answered a question. This is the url in the email for "Mark this problem as solved": 

https://support.allizom.org/en-US/questions/972883/solve/48481%205?watch=wrULRRfFcM

Notice the %20 before the ? in the url, which is space, which causes a 404. This is probably big deal, because it is stopping people from marking questions as solved, and probably discouraging them from returning to the question.

Comment 1

[Kadir Topal [:atopal]]

Not sure right now, but when I was testing this the last time, it was only on staging.

Comment 2

[Ricky Rosario [:rrosario, :r1cky]]

Very weird. I see this in the email template:

    {% trans url='http://' + host + solution_url %}
      If this answer solves your problem, please
      <br/><br/>
      <a class="button" style="width: 200px;" href="{{ url }}">Mark it as solved</a>
    {% endtrans %}


solution_url comes from:

    c['solution_url'] = self.answer.get_solution_url(watch=w[0])


get_solution_url() is:

    def get_solution_url(self, watch):
        url = reverse('questions.solve',
                      kwargs={'question_id': self.question_id,
                              'answer_id': self.id})
        return urlparams(url, watch=watch.secret)


I don't see anything that would cause that %20 to appear.

Comment 3

[Ricky Rosario [:rrosario, :r1cky]]

Also, the answer id in this case is: 484815 (https://support.allizom.org/en-US/questions/972883#answer-484815).

No idea how that can turn into 48481%205 ???

Comment 4

[Will Kahn-Greene [:willkg] ET needinfo? me]

Is it possible the line is long and is getting word-wrapped or something like that? If that were true, I'm not sure why we're not seeing it elsewhere. But that's the only thing I can think of that might insert a space somewhere.

Comment 5

[Alejandro López Espinosa]

Hi,
I've been testing the bug but even faking the question_id and the id of the answer to match 972883 and 484815 i didn't reproduce the bug, i also created some tests on allizom and they work so i question if it's been already fixed

Comment 6

[Andrew Truong [:feer56] [:andrewtruong] [:atruong]]

This is most likely resolved at this point. Haven't seen complaints from users.