924004 - Ghost entry in customization palette, causes weirdness in menu panel.

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[Justin Dolske [:Dolske]]

1) Restore defaults
2) Put devtools into menu panel
3) Restore defaults
- Devtools moves back to palette
- Empty "ghost" item (no icon or label) in palette too
3) Drag weird empty one into panel
- All but Preferences and Addons icon are gone from menu panel (maybe sometimes other icons)
- Zpao says those two icons might have been that last contents last time he had been customizing and quit the browser

Also he had a good dozen or so old icons for cruft we've removed, which went away the first time we restored defaults. Can we figure out a way to do that for users who previously ran Australis and need cruft reset? Maybe check to see if an icon in the palette == something we've removed, and reset automagically?

Comment 1

[:Gijs (he/him)]

Is this a dupe of bug 923857?

Comment 2

[:Gijs (he/him)]

(In reply to Justin Dolske [:Dolske] from comment #2)
> Also he had a good dozen or so old icons for cruft we've removed, which went
> away the first time we restored defaults. Can we figure out a way to do that
> for users who previously ran Australis and need cruft reset? Maybe check to
> see if an icon in the palette == something we've removed, and reset
> automagically?

This is weird, because buttons which are no longer available won't show up on a newer build anyway, as we'll look for them by ID and the ID will be gone. What kind of buttons are these?

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

I saw this the other day. My ghost item was a spring, but I couldn't figure out how it got there.

Comment 4

[:Gijs (he/him)]

(In reply to Jared Wein [:jaws] from comment #3)
> I saw this the other day. My ghost item was a spring, but I couldn't figure
> out how it got there.

That sounds like it's being chucked out of the add-on bar by the migration code. Try reproducing by creating a new profile on trunk, install an add-on that puts an icon there, and then use the profile on UX?

Comment 5

[:Gijs (he/him)]

(In reply to :Gijs Kruitbosch from comment #4)
> (In reply to Jared Wein [:jaws] from comment #3)
> > I saw this the other day. My ghost item was a spring, but I couldn't figure
> > out how it got there.
> 
> That sounds like it's being chucked out of the add-on bar by the migration
> code. Try reproducing by creating a new profile on trunk, install an add-on
> that puts an icon there, and then use the profile on UX?

That being said, I did think I added code to the add-on bar migration code that prevented these kinds of items from being put in the palette... but maybe that was all in my mind?

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

Good insight, I had been switching between non-UX and UX using the same profile.

Comment 7

[:Gijs (he/him)]

(In reply to Jared Wein [:jaws] from comment #6)
> Good insight, I had been switching between non-UX and UX using the same
> profile.

However, I've been trying to reproduce this by installing an add-on in the add-on bar, and then switching to a UX build and resetting, but I've been unsuccessful so far...

Comment 8

[:Gijs (he/him)]

There's at least a thing in buildArea which I just fixed locally as part of some other bug. Bit distracted with triage right now. Will hopefully remember to add a patch later today.

Comment 9

[:Gijs (he/him)]

Attachment: buildArea should just plain remove special items,

This should help.

Comment 10

[:Gijs (he/him)]

https://hg.mozilla.org/projects/ux/rev/ba597861f734

I'm marking this as fixed-in-ux. If people can still reproduce this on/after tomorrow's nightly, it should probably be reopened with STR.

Comment 11

[:Gijs (he/him)]

https://hg.mozilla.org/mozilla-central/rev/ba597861f734