Closed
Bug 924012
Opened 11 years ago
Closed 11 years ago
Provide a HashString version for char16_t if needed
Categories
(Core :: MFBT, defect)
Tracking
()
RESOLVED
FIXED
mozilla27
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
Details
Attachments
(1 file)
|
1.35 KB,
patch
|
Waldo
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #814017 -
Flags: review?(jwalden+bmo)
|
||
Comment 1•11 years ago
|
||
Comment on attachment 814017 [details] [diff] [review]
Patch (v1)
Review of attachment 814017 [details] [diff] [review]:
-----------------------------------------------------------------
::: mfbt/HashFunctions.h
@@ +331,5 @@
> +MOZ_WARN_UNUSED_RESULT
> +inline uint32_t
> +HashString(const char16_t* str)
> +{
> + return detail::HashUntilZero(str);
I'm mildly saddened that we even have a hash-til-zero, but I guess this is symptomatic of our not considering ranges as pointer-plus-length in general, not something particular here. :-\
Attachment #814017 -
Flags: review?(jwalden+bmo) → review+
|
Assignee | |
Comment 2•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
You need to log in
before you can comment on or make changes to this bug.
Description
•