924055 - Does not use libnotify popups

Status: RESOLVED DUPLICATE of bug 858919

(Core :: Widget: Gtk, defect)

Description

[drago01]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Firefox/24.0 (Beta/Release)
Build ID: 20130917102605

Steps to reproduce:

Firefox (starting around 22 or so and thunderbird 24) no longer use libnotify popups (running under GNOME3) but fall back to using XUL notifications.

Both are built using "--enable-libnotify" (Fedora 19 packages).

I have checked the code (toolkit/system/gnome/nsAlertsIconListener.cpp) it falls back to XUL notifications when the notify server does not support actions:

    if (server_caps) {
      gHasCaps = true;
      for (GList* cap = server_caps; cap != NULL; cap = cap->next) {
        if (!strcmp((char*) cap->data, "actions")) {
          gHasActions = true;
          break;
        }
      }
      g_list_foreach(server_caps, (GFunc)g_free, NULL);
      g_list_free(server_caps);
    }

...


  if (!gHasCaps) {
    // if notify_get_server_caps() failed above we need to assume
    // there is no notification-server to display anything
    return NS_ERROR_FAILURE;
  }

  if (!gHasActions && aAlertTextClickable)
    return NS_ERROR_FAILURE; // No good, fallback to XUL

GNOME3 does support actions and running a small test program shows that it has the caps:

actions
action-icons
body
body-markup
icon-static
persistence
sound

So should be good enough. libnotify.so.4 is present ...


Actual results:

No libnotify popup. (Falls back to XUL)


Expected results:

Use native (i.e libnotify) popups.

Comment 1

[drago01]

Attachment: notify-debug.patch

I have tried to debug with the attached patch and it seems not to call into the code at all.