924071 - Resource's source is null when the resource is an empty file

Status: RESOLVED FIXED

(L20n :: JS Library, defect, P1)

Description

[Staś Małolepszy :stas]

This causes the parser to fail badly in:

  function parse(string) {
    _source = string;
    _index = 0; 
    _length = _source.length;  // <== here
    return getLOL();
  }

Comment 1

[Staś Małolepszy :stas]

Attachment: Empty text is okay

Michał, does this help?

Comment 2

[Michał Gołębiowski-Owczarek [:mgol]]

That seems better since I now have more readable error messages but I still do have ones:

TranslationError {name: "TranslationError", message: "[pl] NationalLibrary: Not found", entity: "NationalLibrary", supportedLocales: Array[1], locale: "pl"…}
 l20n.js:1135
RuntimeError {name: "RuntimeError", message: "NationalLibrary: Unable to get translation; tried pl", entity: "NationalLibrary", supportedLocales: Array[1], constructor: function…}

It's caused by the fact that Chrome for some reason returns status code 0 on some l20n files, though if I look later at the network tab I see status 200 so it gets delivered finally, but producing these ugly errors before. :/

Comment 3

[Zibi Braniecki [:zbraniecki][:gandalf]]

Yeah, that's my worry about switching our IO to use readyState and reacting to code 0. I'd like to get back to using only 200, but that seems to make a mess for local/emulation cases.

Comment 4

[Michał Gołębiowski-Owczarek [:mgol]]

(In reply to Zbigniew Braniecki [:gandalf] from comment #3)
> Yeah, that's my worry about switching our IO to use readyState and reacting
> to code 0. I'd like to get back to using only 200, but that seems to make a
> mess for local/emulation cases.

What local/emulation cases? Anyway, this needs to be resolved in some way since these errors really flood the console which makes debugging real problems a little harder.

Comment 5

[Michał Gołębiowski-Owczarek [:mgol]]

Weird enough, I stopped seeing this error in Chrome stable. I do see it in Canary, but it might be a fault of this browser so I'm not sure if there's anything that can be done, unfortunately... :/

Comment 6

[Michał Gołębiowski-Owczarek [:mgol]]

Comment on attachment 814064 [details] [diff] [review]
Empty text is okay

Review of attachment 814064 [details] [diff] [review]:
-----------------------------------------------------------------

This doesn't necessarily remove all the potential errors but makes them bubble up to be handled on a higher level which makes for more readable error messages.

Comment 7

[Staś Małolepszy :stas]

I tried to debug this, and came to a conclusion that this patch fixes a different bug.  Hence the change of the bug summary.

For the issue that Michał reported, I think we should file a separate bug and investigate.  I tried Chrome Canary but was unable to reproduce status code 0 for the XHRs.

Comment 8

[Staś Małolepszy :stas]

Fixed: https://github.com/l20n/l20n.js/commit/7386375977872d63a28c879e41afd56701ed1635