924095 - Edit mode in collections is not align with the homescreen UX

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Everything.me, defect)

Description

[Cristian Rodriguez (:crdlc)]

The bumping animation only affects to images not labels.

Comment 1

[Cristian Rodriguez (:crdlc)]

Sorry for my mistake: bumping -> jumping, bouncing

Comment 2

[Cristian Rodriguez (:crdlc)]

Please ask for approval when the patch will be landed

Comment 3

[Amir Nissim (:amirn)]

problem is in CSS https://github.com/mozilla-b2g/gaia/blob/master/apps/homescreen/style/dragdrop.css#L47

Comment 4

[Cristian Rodriguez (:crdlc)]

Are you saying that the problem is in dragdrop.css?

Comment 5

[Cristian Rodriguez (:crdlc)]

Really the problem in that CSS is the comment but not the implementation :) Until now, only images jump in edit mode, no labels. You can install v1-train or v1.0.1 in order to see the behavior.

Comment 6

[Amir Nissim (:amirn)]

(In reply to Cristian Rodriguez (:crdlc) from comment #4)
> Are you saying that the problem is in dragdrop.css?

no, sorry :)
the problem is in E.me CSS

Comment 7

[Evyatar 'Tron' Amitay (everything.me)]

Attachment: Patch - redirect to github PR

Separated the icon from the name of the app - each of them in its own IMG now. When in edit mode - animating only he icon (without the name).

As far as I could measure, I think there's a reduction of about 3-4 FPS wen scrolling. But I'd appreciate more measures for this, since it's manual and can be affected by other stuff.

Comment 8

[Cristian Rodriguez (:crdlc)]

Comment on attachment 814346 [details]
Patch - redirect to github PR

It works like a charm, thanks a lot

Comment 9

[Ran Ben Aharon [:ranbena] EverythingMe]

Comment on attachment 814346 [details]
Patch - redirect to github PR

I see a drop in 1-2 fps. Other than that - looks good.

Comment 10

[Evyatar 'Tron' Amitay (everything.me)]

merged into master
122ff8c6363227501f4121e5a3892ba41d4c0417

https://github.com/mozilla-b2g/gaia/commit/122ff8c6363227501f4121e5a3892ba41d4c0417