Closed
Bug 924098
Opened 12 years ago
Closed 12 years ago
Error in allDownloadsViewOverlay.js: reason is undefined
Categories
(Firefox :: Downloads Panel, defect)
Firefox
Downloads Panel
Tracking
()
RESOLVED
FIXED
Firefox 27
People
(Reporter: Gijs, Assigned: avp)
Details
(Whiteboard: [good-first-bug][mentor=Gijs][lang=js])
Attachments
(1 file)
|
1.15 KB,
patch
|
Gijs
:
review+
|
Details | Diff | Splinter Review |
When getting file information fails because the file has been removed, this code runs:
http://mxr.mozilla.org/mozilla-central/source/browser/components/downloads/content/allDownloadsViewOverlay.js?rev=0cec45944008&mark=262#261
Unfortunately, there's a mismatch in the variable names there, and so instead of the code working, it throws a JS error. The code on line 262 should also be using aReason.
|
||
Comment 1•12 years ago
|
||
good catch!
|
Assignee | |
Comment 2•12 years ago
|
||
I would like to work on this bug !
|
Reporter | |
Updated•12 years ago
|
Assignee: nobody → abhishekp.bugzilla
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 3•12 years ago
|
||
Attachment #815727 -
Flags: review?(gijskruitbosch+bugs)
|
|
Reporter | |
Comment 4•12 years ago
|
||
Comment on attachment 815727 [details] [diff] [review]
Fixed mismatch in variable name |aReason| in allDownloadsViewOverlay.js
Looks good to me!
Attachment #815727 -
Flags: review?(gijskruitbosch+bugs) → review+
|
|
Reporter | |
Comment 5•12 years ago
|
||
Landed in fx-team: https://hg.mozilla.org/integration/fx-team/rev/1ea7f580adf7
Thanks for the patch!
Whiteboard: [good-first-bug][mentor=Gijs][lang=js] → [good-first-bug][mentor=Gijs][lang=js][fixed-in-fx-team]
|
||
Comment 6•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [good-first-bug][mentor=Gijs][lang=js][fixed-in-fx-team] → [good-first-bug][mentor=Gijs][lang=js]
Target Milestone: --- → Firefox 27
You need to log in
before you can comment on or make changes to this bug.
Description
•