All users were logged out of Bugzilla on October 13th, 2018

Error in allDownloadsViewOverlay.js: reason is undefined

RESOLVED FIXED in Firefox 27

Status

()

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Gijs, Assigned: avp)

Tracking

unspecified
Firefox 27
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good-first-bug][mentor=Gijs][lang=js])

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
When getting file information fails because the file has been removed, this code runs:

http://mxr.mozilla.org/mozilla-central/source/browser/components/downloads/content/allDownloadsViewOverlay.js?rev=0cec45944008&mark=262#261

Unfortunately, there's a mismatch in the variable names there, and so instead of the code working, it throws a JS error. The code on line 262 should also be using aReason.
good catch!
(Assignee)

Comment 2

5 years ago
I would like to work on this bug !
(Reporter)

Updated

5 years ago
Assignee: nobody → abhishekp.bugzilla
Status: NEW → ASSIGNED
(Assignee)

Comment 3

5 years ago
Created attachment 815727 [details] [diff] [review]
Fixed mismatch in variable name |aReason| in allDownloadsViewOverlay.js
Attachment #815727 - Flags: review?(gijskruitbosch+bugs)
(Reporter)

Comment 4

5 years ago
Comment on attachment 815727 [details] [diff] [review]
Fixed mismatch in variable name |aReason| in allDownloadsViewOverlay.js

Looks good to me!
Attachment #815727 - Flags: review?(gijskruitbosch+bugs) → review+
(Reporter)

Comment 5

5 years ago
Landed in fx-team: https://hg.mozilla.org/integration/fx-team/rev/1ea7f580adf7

Thanks for the patch!
Whiteboard: [good-first-bug][mentor=Gijs][lang=js] → [good-first-bug][mentor=Gijs][lang=js][fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/1ea7f580adf7
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [good-first-bug][mentor=Gijs][lang=js][fixed-in-fx-team] → [good-first-bug][mentor=Gijs][lang=js]
Target Milestone: --- → Firefox 27
You need to log in before you can comment on or make changes to this bug.