Closed Bug 924107 Opened 7 years ago Closed 7 years ago

Make dist/include available in all of the WebRTC code

Categories

(Core :: WebRTC, defect)

Product:
Core
Component:
WebRTC
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla27

People

(Reporter: ehsan, Assigned: ehsan)

References

Details

Attachments

(1 file)

Patch (v1)
5.69 KB, patch
jesup
: review+
glandium
: review+
Details | Diff | Splinter Review
Attached patch Patch (v1) — — Splinter Review 
We need to #include mozilla/Char16.h everywhere in our code with bug 895047.  This patch makes dist/include available in all of the WebRTC code.
Attachment #814120 - Flags: review?(rjesup)
Don't forget to get a build peer to review.
Attachment #814120 - Flags: review?(mh+mozilla)
Attachment #814120 - Flags: review?(gps)
Attachment #814120 - Flags: review?(mh+mozilla)
Attachment #814120 - Flags: review?(gps)
Attachment #814120 - Flags: review+
Comment on attachment 814120 [details] [diff] [review]
Patch (v1)

Review of attachment 814120 [details] [diff] [review]:
-----------------------------------------------------------------

You missed the uses of $(DIST)/include - opus.gypi, vp8.gyp, video_capture.gypi
Likely all the  dist/include's in .gyp* files should use either $(DEPTH)/dist/include, or $(DIST)/include (probably better)

r+ if you fix those too and run a try (build debug on each; shouldn't need tests or opt builds - just make sure all the includes work out).
Attachment #814120 - Flags: review?(rjesup) → review+
Note that media/webrtc/trunk/webrtc/modules/audio_coding/codecs/opus/opus.gypi adds $(DIST)/include/opus, so I can't take that one out.

https://tbpl.mozilla.org/?tree=Try&rev=7fd887bd2055
https://hg.mozilla.org/mozilla-central/rev/489e596e0359
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
You need to log in before you can comment on or make changes to this bug.