924107 - Make dist/include available in all of the WebRTC code

Status: RESOLVED FIXED

(Core :: WebRTC, defect)

Description

[(no longer active)]

Attachment: Patch (v1)

We need to #include mozilla/Char16.h everywhere in our code with bug 895047.  This patch makes dist/include available in all of the WebRTC code.

Comment 1

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Don't forget to get a build peer to review.

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 814120 [details] [diff] [review]
Patch (v1)

Review of attachment 814120 [details] [diff] [review]:
-----------------------------------------------------------------

You missed the uses of $(DIST)/include - opus.gypi, vp8.gyp, video_capture.gypi
Likely all the  dist/include's in .gyp* files should use either $(DEPTH)/dist/include, or $(DIST)/include (probably better)

r+ if you fix those too and run a try (build debug on each; shouldn't need tests or opt builds - just make sure all the includes work out).

Comment 3

[(no longer active)]

Note that media/webrtc/trunk/webrtc/modules/audio_coding/codecs/opus/opus.gypi adds $(DIST)/include/opus, so I can't take that one out.

https://tbpl.mozilla.org/?tree=Try&rev=7fd887bd2055

Comment 4

[(no longer active)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/489e596e0359

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/489e596e0359