No description provided.
Attachment #814190 - Flags: review?(jgilbert)
Comment on attachment 814190 [details] [diff] [review] attrib0-enum Review of attachment 814190 [details] [diff] [review]: ----------------------------------------------------------------- ::: content/canvas/src/WebGLTypes.h @@ +66,5 @@ > + * emulating the vertex attrib 0 array when it's not enabled. Indeed, > + * OpenGL ES 2.0 allows drawing without vertex attrib 0 array enabled, but > + * desktop OpenGL does not allow that. > + */ > +MOZ_BEGIN_ENUM_CLASS(WebGLVertexAttrib0Status, int) We should probably switch to a webgl:: namespace at some point, instead of having WebGL* prefixes on everything.
Attachment #814190 - Flags: review?(jgilbert) → review+
(In reply to Jeff Gilbert [:jgilbert] from comment #1) > We should probably switch to a webgl:: namespace at some point, instead of > having WebGL* prefixes on everything. nested namespaces are frowned upon by many gecko developers, as is evident from many dev-platform discussions. Not sure that I remember the reason, but if you're interested, there are some threads to read, like https://groups.google.com/forum/#!topic/mozilla.dev.platform/L809txbobEU https://groups.google.com/forum/#!topic/mozilla.dev.platform/U_YGHuChdFk
" Modules should avoid adding nested namespaces under "mozilla" unless they are meant to contain names which have a high probability of colliding with other names in the code base (e.g., Point, Path, etc.). Such symbols can be put under module-specific namespaces under "mozilla", with short all-lowercase names." That sounds like us, since we would have Texture, Renderbuffer, etc. Right now, we're doing pseudo-namespaces with prefixes, which isn't really better. It just means that I get tired of putting WebGL in front of everything. Basically, we should use no-prefix, no-namespace if we're not concerned about collisions, prefixed if we've hit a collision, and namespaced if we have a bunch of collide-y things. We're definitely in either the former or the latter.
Assignee: nobody → bjacob
Target Milestone: --- → mozilla27
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.