Closed
Bug 924192
Opened 11 years ago
Closed 11 years ago
Use MOZ_BEGIN_ENUM_CLASS for the WebGLTexelPremultiplicationOp enum
Categories
(Core :: Graphics: CanvasWebGL, defect)
Core
Graphics: CanvasWebGL
Tracking
()
RESOLVED
FIXED
mozilla27
People
(Reporter: bjacob, Assigned: bjacob)
Details
Attachments
(2 files)
23.04 KB,
patch
|
jgilbert
:
review+
|
Details | Diff | Splinter Review |
23.07 KB,
patch
|
bjacob
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #814192 -
Flags: review?(jgilbert)
Comment 1•11 years ago
|
||
Comment on attachment 814192 [details] [diff] [review] patch Review of attachment 814192 [details] [diff] [review]: ----------------------------------------------------------------- ::: content/canvas/src/WebGLTexelConversions.h @@ +338,5 @@ > //---------------------------------------------------------------------- > // Pixel packing routines. > // > > +template<MOZ_ENUM_CLASS_INTEGER_TYPE(WebGLTexelFormat) Format, MOZ_ENUM_CLASS_INTEGER_TYPE(WebGLTexelPremultiplicationOp) PremultiplicationOp, typename SrcType, typename DstType> This is so gross. Split it to multiple lines to try to salvage something readable.
Attachment #814192 -
Flags: review?(jgilbert) → review+
Assignee | ||
Comment 2•11 years ago
|
||
Attachment #814272 -
Flags: review+
Assignee | ||
Comment 3•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/447425c70633
Assignee: nobody → bjacob
Target Milestone: --- → mozilla27
Comment 4•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/447425c70633
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•