Closed Bug 924192 Opened 8 years ago Closed 8 years ago

Use MOZ_BEGIN_ENUM_CLASS for the WebGLTexelPremultiplicationOp enum

Categories

(Core :: Canvas: WebGL, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla27

People

(Reporter: bjacob, Assigned: bjacob)

Details

Attachments

(2 files)

Attached patch patchSplinter Review
No description provided.
Attachment #814192 - Flags: review?(jgilbert)
Comment on attachment 814192 [details] [diff] [review]
patch

Review of attachment 814192 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/canvas/src/WebGLTexelConversions.h
@@ +338,5 @@
>  //----------------------------------------------------------------------
>  // Pixel packing routines.
>  //
>  
> +template<MOZ_ENUM_CLASS_INTEGER_TYPE(WebGLTexelFormat) Format, MOZ_ENUM_CLASS_INTEGER_TYPE(WebGLTexelPremultiplicationOp) PremultiplicationOp, typename SrcType, typename DstType>

This is so gross.
Split it to multiple lines to try to salvage something readable.
Attachment #814192 - Flags: review?(jgilbert) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/447425c70633
Assignee: nobody → bjacob
Target Milestone: --- → mozilla27
https://hg.mozilla.org/mozilla-central/rev/447425c70633
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.