Closed Bug 924193 Opened 6 years ago Closed 6 years ago

Drop WebGLTexelConversions' custom FORCE_INLINE macro, use MOZ_ALWAYS_INLINE

Categories

(Core :: Canvas: WebGL, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla27

People

(Reporter: bjacob, Assigned: bjacob)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch always-inline (obsolete) — Splinter Review
The situation that FORCE_INLINE was working around, was what bug 800106 fixed.
Attachment #814193 - Flags: review?(jgilbert)
Comment on attachment 814193 [details] [diff] [review]
always-inline

Review of attachment 814193 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/canvas/src/WebGLTexelConversions.h
@@ +690,5 @@
>      dst[2] = src[2] * scaleFactor;
>      dst[3] = src[3] * scaleFactor;
>  }
>  
> +#undef MOZ_ALWAYS_INLINE

Nope!
Attachment #814193 - Flags: review?(jgilbert) → review-
Attached patch patchSplinter Review
That is exactly what reviews are for! Thanks!
Attachment #814193 - Attachment is obsolete: true
Attachment #814273 - Flags: review?(jgilbert)
Try push with all my recent unlanded stuff:
https://tbpl.mozilla.org/?tree=Try&rev=4c150f696170
Looks like Windows needs the tweak for enum classes too:
https://tbpl.mozilla.org/?tree=Try&rev=1356d79d792c
Attachment #814273 - Flags: review?(jgilbert) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/5779d659976a
Assignee: nobody → bjacob
Target Milestone: --- → mozilla27
https://hg.mozilla.org/mozilla-central/rev/5779d659976a
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.