Drop WebGLTexelConversions' custom FORCE_INLINE macro, use MOZ_ALWAYS_INLINE

RESOLVED FIXED in mozilla27

Status

()

Core
Canvas: WebGL
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: bjacob, Assigned: bjacob)

Tracking

Trunk
mozilla27
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Created attachment 814193 [details] [diff] [review]
always-inline

The situation that FORCE_INLINE was working around, was what bug 800106 fixed.
Attachment #814193 - Flags: review?(jgilbert)
Comment on attachment 814193 [details] [diff] [review]
always-inline

Review of attachment 814193 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/canvas/src/WebGLTexelConversions.h
@@ +690,5 @@
>      dst[2] = src[2] * scaleFactor;
>      dst[3] = src[3] * scaleFactor;
>  }
>  
> +#undef MOZ_ALWAYS_INLINE

Nope!
Attachment #814193 - Flags: review?(jgilbert) → review-
(Assignee)

Comment 2

4 years ago
Created attachment 814273 [details] [diff] [review]
patch

That is exactly what reviews are for! Thanks!
Attachment #814193 - Attachment is obsolete: true
Attachment #814273 - Flags: review?(jgilbert)
(Assignee)

Comment 3

4 years ago
Try push with all my recent unlanded stuff:
https://tbpl.mozilla.org/?tree=Try&rev=4c150f696170
(Assignee)

Comment 4

4 years ago
Looks like Windows needs the tweak for enum classes too:
https://tbpl.mozilla.org/?tree=Try&rev=1356d79d792c
Attachment #814273 - Flags: review?(jgilbert) → review+
(Assignee)

Comment 6

4 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/5779d659976a
Assignee: nobody → bjacob
Target Milestone: --- → mozilla27
https://hg.mozilla.org/mozilla-central/rev/5779d659976a
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.