924193 - Drop WebGLTexelConversions' custom FORCE_INLINE macro, use MOZ_ALWAYS_INLINE

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[Benoit Jacob [:bjacob] (mostly away)]

Attachment: always-inline

The situation that FORCE_INLINE was working around, was what bug 800106 fixed.

Comment 1

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 814193 [details] [diff] [review]
always-inline

Review of attachment 814193 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/canvas/src/WebGLTexelConversions.h
@@ +690,5 @@
>      dst[2] = src[2] * scaleFactor;
>      dst[3] = src[3] * scaleFactor;
>  }
>  
> +#undef MOZ_ALWAYS_INLINE

Nope!

Comment 2

[Benoit Jacob [:bjacob] (mostly away)]

Attachment: patch

That is exactly what reviews are for! Thanks!

Comment 3

[Benoit Jacob [:bjacob] (mostly away)]

Try push with all my recent unlanded stuff:
https://tbpl.mozilla.org/?tree=Try&rev=4c150f696170

Comment 4

[Benoit Jacob [:bjacob] (mostly away)]

Looks like Windows needs the tweak for enum classes too:
https://tbpl.mozilla.org/?tree=Try&rev=1356d79d792c

Comment 5

[Benoit Jacob [:bjacob] (mostly away)]

rather this: https://tbpl.mozilla.org/?tree=Try&rev=0a72627c7d81

Comment 6

[Benoit Jacob [:bjacob] (mostly away)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5779d659976a

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/5779d659976a