924213 - Add french locale to all the apps

Status: RESOLVED FIXED

(Webmaker Graveyard :: webmaker.org, defect)

Description

[Ali Al Dallal [:alicoding]]

Add french locale to all the apps

Comment 1

[Ali Al Dallal [:alicoding]]

Attachment: https://github.com/mozilla/webmaker.org/pull/412

Comment 2

[Ali Al Dallal [:alicoding]]

Attachment: https://github.com/mozilla/login.webmaker.org/pull/180

Comment 3

[David Humphrey (:humph)]

I'm wondering about why you did fr-FR vs. just fr here?  I notice that in Transifex they have it as just fr, and I think we should probably keep that, and do mappings for things like fr-FR, fr-CA, etc back to fr.  French is a good example of a language we should keep untangled from regional claims, until we actually have people who want to localize it for a region.

Comment 4

[Brett Gaylor [:brett]]

not sure if this is the implication, but fr-CA should have the option of it's own localized strings.  In Quebec they actually have many more words for computer terminology than are used in France, for example.

Comment 5

[David Humphrey (:humph)]

We can add fr-CA when we have those strings, yes.  But unless we actually have a country-specific locale, it's much better for us to present it just as a language.

Comment 6

[Ali Al Dallal [:alicoding]]

Attachment: https://github.com/mozilla/popcorn.webmaker.org/pull/247

Comment 7

[Ali Al Dallal [:alicoding]]

Attachment: https://github.com/mozilla/thimble.webmaker.org/pull/248

Comment 8

[Ali Al Dallal [:alicoding]]

Attachment: https://github.com/mozilla/goggles.webmaker.org/pull/42

Comment 9

[Ali Al Dallal [:alicoding]]

Attachment: https://github.com/mozilla/make-valet/pull/20/files

Comment 10

[[github robot]]

Commit pushed to master at https://github.com/mozilla/login.webmaker.org

https://github.com/mozilla/login.webmaker.org/commit/e05f0498f79308bed36e805ab48b6928e0698ad3
bug924213 - Add Frnech locale

Comment 11

[[github robot]]

Commit pushed to master at https://github.com/mozilla/popcorn.webmaker.org

https://github.com/mozilla/popcorn.webmaker.org/commit/62d2d542ec5d47525ed79a7f68536131c43c83d3
bug924213 - Add French locale

Comment 12

[[github robot]]

Commit pushed to master at https://github.com/mozilla/thimble.webmaker.org

https://github.com/mozilla/thimble.webmaker.org/commit/1b20bc53f14390d95143b25d59366f925b1e6a0e
bug924213 - Add French locale

Comment 13

[[github robot]]

Commit pushed to master at https://github.com/mozilla/make-valet

https://github.com/mozilla/make-valet/commit/e8795e50270b07c2da5f588049e1a6172f2d7b94
bug924213 - Add Frnech locale

Comment 14

[Ali Al Dallal [:alicoding]]

Commit pushed to amster at https://github.com/mozilla/goggles.webmaker

https://github.com/mozilla/goggles.webmaker.org/commit/92b98c1446682c59a576af212ec89a0e680be5b1
bug924213 - Add Frnech locale

Comment 15

[[github robot]]

Commit pushed to master at https://github.com/mozilla/webmaker.org

https://github.com/mozilla/webmaker.org/commit/dbe19609c5aa845610b728c1b3cdf9991117d4a7
bug924213 - Add French locale