Closed Bug 924232 Opened 7 years ago Closed 7 years ago

Harmonize preprocessing of FENNEC_PP_JAVA_VIEW_FILES

Categories

(Firefox for Android :: General, defect)

All
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 27

People

(Reporter: nalexander, Assigned: nalexander)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

At the moment, we have an ad-hoc rule for generating Gecko{VIEW}.java from GeckoView.java.frag.  This complicates the build system and gets in the way of creating IDE projects.  Time to harmonize it with our existing preprocessing.
This simplifies the build system and will help us generate IDE project
files.  It costs us extra stub .java.in files.  This is a good trade.
mfinkle, sriram: am I missing anything subtle?
Attachment #814229 - Flags: review?(mark.finkle)
Attachment #814229 - Flags: feedback?
Comment on attachment 814229 [details] [diff] [review]
Harmonize preprocessing of FENNEC_PP_JAVA_VIEW_FILES. r=mfinkle

This works for me -- explicit files sure beat implicit build logic -- except that these are appearing in mobile/android/base!

So step 0 is to move them into /view/...
Attachment #814229 - Flags: feedback? → feedback+
> So step 0 is to move them into /view/...

:sriram, is this cool?  The package is currently defined as org.mozilla.gecko, but I'm happy to move them to view/.
Flags: needinfo?(sriram)
Some of them (most?) are actually widgets.
(In reply to Wesley Johnston (:wesj) from comment #4)
> Some of them (most?) are actually widgets.

Agreed. These should go in the "widget" folder. Even Android agrees, for once:
http://androidxref.com/4.3_r2.1/xref/frameworks/base/core/java/android/widget/
Comment on attachment 814229 [details] [diff] [review]
Harmonize preprocessing of FENNEC_PP_JAVA_VIEW_FILES. r=mfinkle

r+ with the move to widget
Attachment #814229 - Flags: review?(mark.finkle) → review+
When you move it to a different folder, please update the XML files too.
E.g.: https://hg.mozilla.org/mozilla-central/file/tip/mobile/android/base/resources/layout/tabs_counter.xml
I am fine with moving them, preferably to widget/.
Flags: needinfo?(sriram)
https://hg.mozilla.org/mozilla-central/rev/a222b928494d
https://hg.mozilla.org/mozilla-central/rev/2618d8170c70
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 27
You need to log in before you can comment on or make changes to this bug.