924232 - Harmonize preprocessing of FENNEC_PP_JAVA_VIEW_FILES

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Nick Alexander :nalexander [he/him]]

At the moment, we have an ad-hoc rule for generating Gecko{VIEW}.java from GeckoView.java.frag.  This complicates the build system and gets in the way of creating IDE projects.  Time to harmonize it with our existing preprocessing.

Comment 1

[Nick Alexander :nalexander [he/him]]

Attachment: Harmonize preprocessing of FENNEC_PP_JAVA_VIEW_FILES. r=mfinkle

This simplifies the build system and will help us generate IDE project
files.  It costs us extra stub .java.in files.  This is a good trade.
mfinkle, sriram: am I missing anything subtle?

Comment 2

[Richard Newman [:rnewman]]

Comment on attachment 814229 [details] [diff] [review]
Harmonize preprocessing of FENNEC_PP_JAVA_VIEW_FILES. r=mfinkle

This works for me -- explicit files sure beat implicit build logic -- except that these are appearing in mobile/android/base!

So step 0 is to move them into /view/...

Comment 3

[Nick Alexander :nalexander [he/him]]

> So step 0 is to move them into /view/...

:sriram, is this cool?  The package is currently defined as org.mozilla.gecko, but I'm happy to move them to view/.

Comment 4

[Wesley Johnston (:wesj)]

Some of them (most?) are actually widgets.

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Wesley Johnston (:wesj) from comment #4)
> Some of them (most?) are actually widgets.

Agreed. These should go in the "widget" folder. Even Android agrees, for once:
http://androidxref.com/4.3_r2.1/xref/frameworks/base/core/java/android/widget/

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 814229 [details] [diff] [review]
Harmonize preprocessing of FENNEC_PP_JAVA_VIEW_FILES. r=mfinkle

r+ with the move to widget

Comment 7

[Sriram Ramasubramanian [:sriram]]

When you move it to a different folder, please update the XML files too.
E.g.: https://hg.mozilla.org/mozilla-central/file/tip/mobile/android/base/resources/layout/tabs_counter.xml
I am fine with moving them, preferably to widget/.

Comment 8

[Nick Alexander :nalexander [he/him]]

https://hg.mozilla.org/integration/fx-team/rev/a222b928494d
https://hg.mozilla.org/integration/fx-team/rev/2618d8170c70

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a222b928494d
https://hg.mozilla.org/mozilla-central/rev/2618d8170c70