924250 - [B2G] [SMS] Unable to add wallpapers to MMS message

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Chris Kreinbring [:CKreinbring]]

Attachment: Screenshot of MMS file source options

Description:
A user attempting to attach a wallpaper to an MMS message will be unable to because the option is not shown in the file source selection menu.

Repro Steps:
1) Update Buri to Build ID: 20131007004003
2) Launch the Messaging app.
3) Tap the New Message icon in the upper right corner, then the paperclip icon in the lower left corner.
4) Observe the options available for attaching to a text message.

Actual:
Wallpaper is not in the list of file sources.

Expected:
Wallpaper is in the list of file sources.

Environmental Variables
Device: Buri 1.2 mozilla RIL
Build ID: 20131007004003
Gecko: http://hg.mozilla.org/releases/mozilla-aurora/rev/f067799dff06
Gaia: 85c4af3f48a91878d565f518ba0eed68f0628e21
Platform Version: 26.0a2

Notes:
Repro frequency: 100%
Test Suite Name: SMS
UCID: messages-001
Link to failed test case: https://moztrap.mozilla.org/manage/cases/?filter-id=7914
See attached screenshot

Comment 1

[Julien Wajsberg [:julienw]]

I was told it was done on purpose. I think this change comes from bug 905856, so maybe David will know more.

Comment 2

[David Flanagan [:djf]]

When I first implemented the wallpaper app, I originally tried to set it up so that it would only respond to activities if the activity request was for an image with the same size as the screen. This was so that you wouldn't see the Wallpaper app as a choice when (for example) picking an image for the contacts app.
The idea was that if you wanted wallpaper, you'd explicitly specify the size of the image you wanted and the wallpaper app would magically turn up.

But then we changed the way activities filters work, and then we started supporting different screen sizes, and somewhere along the way, the Wallpaper app must have started appearing when you try to attach something to a MMS message.

I claim that no one ever actually wrote a user story that says "as a user, I want to be able to attach system wallpaper images to my MMS messages".  I'm guessing that it just happened to work that way and that someone therefore created a test case around it.

I argue that it is better that wallpaper does not show up when you are attaching things to text messages.  And that this bug can just be closed as WONTFIX (and the test suite updated appropriately).

Alternatively, you could fix this by adding "wallpaper" as one of the pick types in the MMS app.  But if you do that, then you probably also want to enable attaching ringtones, so you should add "ringtones" to the list as well.

Comment 3

[Jason Smith [:jsmith]]

Makes sense.

Comment 4

[Angela Hubenya]

Test case 7914 has been disabled.