Closed
Bug 924257
Opened 11 years ago
Closed 11 years ago
Reduce moz.build/Makefile.in files in /browser/metro tests
Categories
(Firefox for Metro Graveyard :: Tests, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 27
People
(Reporter: mbrubeck, Assigned: mbrubeck)
References
Details
Attachments
(1 file, 1 obsolete file)
4.96 KB,
patch
|
rsilveira
:
review+
Ms2ger
:
review+
|
Details | Diff | Splinter Review |
In response to a plea by gps on dev-platform [1], this patch reduces the number of build steps and build files in our test directory, to help builds run faster. The patch depends on bug 923273. [1] https://groups.google.com/d/topic/mozilla.dev.platform/F-uESi8ByPE/discussion
Attachment #814261 -
Flags: review?(rsilveira)
Assignee | ||
Comment 1•11 years ago
|
||
Comment on attachment 814261 [details] [diff] [review] patch Can we also remove TEST_DIRS from /browser/metro/moz.build? I wonder if we can also get rid of /browser/metro/base/Makefile.in by moving its content up a level...
Attachment #814261 -
Flags: review?(Ms2ger)
Assignee | ||
Comment 2•11 years ago
|
||
The answer is yes, we do need to remove TEST_DIRS.
Attachment #814261 -
Attachment is obsolete: true
Attachment #814261 -
Flags: review?(rsilveira)
Attachment #814261 -
Flags: review?(Ms2ger)
Attachment #814264 -
Flags: review?(rsilveira)
Attachment #814264 -
Flags: review?(Ms2ger)
Comment 3•11 years ago
|
||
Comment on attachment 814264 [details] [diff] [review] patch v2 Review of attachment 814264 [details] [diff] [review]: ----------------------------------------------------------------- r=me on the moz.build changes.
Attachment #814264 -
Flags: review?(Ms2ger) → review+
Updated•11 years ago
|
Attachment #814264 -
Flags: review?(rsilveira) → review+
Assignee | ||
Comment 4•11 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/d7e9a858c4b6
Whiteboard: [fixed-in-fx-team]
Comment 5•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/d7e9a858c4b6
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 27
Updated•10 years ago
|
OS: Windows 8 Metro → Windows 8.1
You need to log in
before you can comment on or make changes to this bug.
Description
•