924378 - [Contacts API] Error in finding matching contacts for international number (00)

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Germán Toro del Valle (:gtorodelvalle)]

navigator.mozContacts.find({filterOp: 'match', filterBy: 'tel'} ) is not retrieving as matching contacts with '00'-type international phone numbers. It is working fine for numbers with no international prefix and numbers with '+'-type international prefix.

For example, in case of 3 contacts with phone numbers 666666666, [phone], 0034666666666. The 666666666 and [phone] ones are detected as matching contacts whereas the 0034666666666 is not.

Comment 1

[Andrew Overholt [:overholt]]

Vicamo, is Gene handling phone number normalization now (I ask because I saw him assign himself on another bug)?

Comment 2

[Joe Cheng [:jcheng] (please needinfo)]

triage: koi+ as it blocks a v1.2 koi+ bug

Comment 3

[Gregor Wagner [:gwagner]]

Attachment: patch

We need a 2nd request that deals with international prefix numbers :(

Comment 4

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 816048 [details] [diff] [review]
patch

Review of attachment 816048 [details] [diff] [review]:
-----------------------------------------------------------------

Ick. r=me with this addressed:

::: dom/contacts/fallback/ContactDB.jsm
@@ +1065,5 @@
> +        } else if (normalized[0] !== "+") {
> +          // We might have an international prefix like '00'
> +          let parsed = PhoneNumberUtils.parse(normalized);
> +          if (parsed && parsed.internationalNumber &&
> +              parsed.nationalNumber !== normalized &&

Shouldn't you check that parsed.nationalNumber exists before moving on here?

Comment 5

[Gregor Wagner [:gwagner]]

https://hg.mozilla.org/integration/b2g-inbound/rev/5a492d7ab6f4

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/5a492d7ab6f4

Comment 7

[Gregor Wagner [:gwagner]]

Can you test this again please?

Comment 8

[Germán Toro del Valle (:gtorodelvalle)]

Bug 904515 which depended on this one works fine now :-) Thank you very much!

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/6c8fcc1e8f84