Closed
Bug 924394
Opened 11 years ago
Closed 11 years ago
Add some more logging for APZC things
Categories
(Core :: Graphics: Layers, defect)
Tracking
()
RESOLVED
FIXED
mozilla27
People
(Reporter: kats, Assigned: kats)
Details
Attachments
(1 file, 1 obsolete file)
8.68 KB,
patch
|
botond
:
review+
|
Details | Diff | Splinter Review |
I often find I need some more logging in APZC to debug things. It would be nice to leave it in the code (disabled by default obviously) and easy to turn on. The patch also updates the APZC_LOG to always prefix the log with "APZC" and use __VA_ARGS__ for better compatibility across platforms.
Attachment #814386 -
Flags: review?(botond)
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → bugmail.mozilla
Comment 1•11 years ago
|
||
Comment on attachment 814386 [details] [diff] [review] Patch Review of attachment 814386 [details] [diff] [review]: ----------------------------------------------------------------- ::: gfx/layers/ipc/AsyncPanZoomController.cpp @@ +1173,5 @@ > mLastContentPaintMetrics = aLayerMetrics; > > bool isDefault = mFrameMetrics.IsDefault(); > mFrameMetrics.mMayHaveTouchListeners = aLayerMetrics.mMayHaveTouchListeners; > + APZC_LOG("%p got a NotifyLayersUpdated with isDefault=%d aIsFirstPaint=%d\n", isDefault, aIsFirstPaint); You're missing an argument for the %p.
Assignee | ||
Comment 2•11 years ago
|
||
Updated to add "this" to go with the %p. Nice catch! I had a few versions of this patch on different branches locally but I guess I grabbed one without that fixed :/
Attachment #814386 -
Attachment is obsolete: true
Attachment #814386 -
Flags: review?(botond)
Attachment #814500 -
Flags: review?(botond)
Updated•11 years ago
|
Attachment #814500 -
Flags: review?(botond) → review+
Assignee | ||
Comment 3•11 years ago
|
||
https://hg.mozilla.org/integration/b2g-inbound/rev/5c9bf84fa5e6
Comment 4•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/5c9bf84fa5e6
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
You need to log in
before you can comment on or make changes to this bug.
Description
•