924407 - Documentation for FrameMetrics::mCompositionBounds needs updating

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

Attachment: 2-cleanup-53b3013

The code was updated in bug 904533 and friends but the docs are still old.

Comment 1

[Botond Ballo [:botond]]

Comment on attachment 814393 [details] [diff] [review]
2-cleanup-53b3013

Review of attachment 814393 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the patch! One question:

::: gfx/layers/FrameMetrics.h
@@ +139,5 @@
>    // where we're prerendering the wrong regions and the content may be clipped,
>    // or too much of it prerendered. If the displayport is the same as the
>    // viewport, there is no need for this and we can just use the viewport
>    // instead.
>    //

Is the sentence "If the displayport is the same as the viewport, there is no need for this and we can just use the viewport instead." still accurate? Should it instead say "If the composition dimensions are the same as the viewport ..."?

Comment 2

[Kartikaya Gupta (email:[e-mail])]

(In reply to Botond Ballo [:botond] from comment #1)
> Is the sentence "If the displayport is the same as the viewport, there is no
> need for this and we can just use the viewport instead." still accurate?
> Should it instead say "If the composition dimensions are the same as the
> viewport ..."?

Yup, you're right. I'll update that too.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Attachment: Patch

Updated

Comment 4

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/integration/b2g-inbound/rev/2ad9dcabe5c6

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2ad9dcabe5c6