Documentation for FrameMetrics::mCompositionBounds needs updating

RESOLVED FIXED in mozilla27

Status

()

Core
Graphics: Layers
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: kats, Assigned: kats)

Tracking

unspecified
mozilla27
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Created attachment 814393 [details] [diff] [review]
2-cleanup-53b3013

The code was updated in bug 904533 and friends but the docs are still old.
Attachment #814393 - Flags: review?(botond)
Comment on attachment 814393 [details] [diff] [review]
2-cleanup-53b3013

Review of attachment 814393 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the patch! One question:

::: gfx/layers/FrameMetrics.h
@@ +139,5 @@
>    // where we're prerendering the wrong regions and the content may be clipped,
>    // or too much of it prerendered. If the displayport is the same as the
>    // viewport, there is no need for this and we can just use the viewport
>    // instead.
>    //

Is the sentence "If the displayport is the same as the viewport, there is no need for this and we can just use the viewport instead." still accurate? Should it instead say "If the composition dimensions are the same as the viewport ..."?
(In reply to Botond Ballo [:botond] from comment #1)
> Is the sentence "If the displayport is the same as the viewport, there is no
> need for this and we can just use the viewport instead." still accurate?
> Should it instead say "If the composition dimensions are the same as the
> viewport ..."?

Yup, you're right. I'll update that too.
Created attachment 814499 [details] [diff] [review]
Patch

Updated
Attachment #814393 - Attachment is obsolete: true
Attachment #814393 - Flags: review?(botond)
Attachment #814499 - Flags: review?(botond)

Updated

4 years ago
Attachment #814499 - Flags: review?(botond) → review+
https://hg.mozilla.org/integration/b2g-inbound/rev/2ad9dcabe5c6
https://hg.mozilla.org/mozilla-central/rev/2ad9dcabe5c6
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
You need to log in before you can comment on or make changes to this bug.