Closed Bug 924410 Opened 8 years ago Closed 8 years ago

don't generate typedefs in Message subclasses

Categories

(Core :: IPC, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla27

People

(Reporter: froydnj, Unassigned)

References

Details

Attachments

(1 file)

There's no reason for them to be there, since Message subclasses are nothing
more than a constructor and a logging method.
It's easier to clean up the generated headers if we don't have to worry about
dealing with these typedefs.  And they're not used anyway!

Ehsan really wants to be an IPDL peer, so it'd be good if he reviewed changes
in that area. ;)
Attachment #814396 - Flags: review?(ehsan)
Comment on attachment 814396 [details] [diff] [review]
don't generate typedefs in Message subclasses

Review of attachment 814396 [details] [diff] [review]:
-----------------------------------------------------------------

Please note that I will reserve the right to go back and back out all of these patches that I'm r+ing if you mention me becoming an IPDL peer again.  ;-)
Attachment #814396 - Flags: review?(ehsan) → review+
https://hg.mozilla.org/mozilla-central/rev/02492cc40f17
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
Blocks: 918651
You need to log in before you can comment on or make changes to this bug.