924483 - [B2G] [Email] "Load more messages from server" overlaps "No mail in this Folder" when there are no messages locally but there may be messages on the server to sync

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::E-Mail, defect)

Description

[sarsenyev]

Description:
When deleting all messages from a folder, the "load more messages from server" message still presents along with "No mail in this Folder" message

Prerequisite:
set up Gmail IMAP account, have a few emails in "Inbox"


Repro Steps:
1) Updated to Buri BuildID 20131004040203
2) Open the email app from the home screen
3) Navigate to the "Inbox" email folder
4) Tap the "check mark" to edit
5) Delete all emails from the folder

Actual:
"Load more messages from server" still as a message

Expected:
Only one message is available "No mail in this Folder"

Device: Buri v 1.3 Mozilla Central)
Gaia   1ac6749e36424124493a1b4c7534f298789bdffd
SourceStamp 8f08240128c8
BuildID 20131004040203
Version 27.0a1
Firmware revision: US_20130912

Notes:
Repro frequency: 100%
Test Suite Name: Email
The issue doesn't reproduce on the latest Aurora 1.2 Moz RIL

See the screenshot

Comment 1

[Andrew Sutherland [:asuth] (he/him)]

From our state machine, it's very legal for us to both have zero messages stored locally but to believe that there are or that there may be more messages on the server.  Especially if you delete all the messages that the device knows about, as deleting messages will never cause us to synchronize further back in time.

It's possible this might create some type of pathological sync situation where we try and synchronize all of the messages in the folder if we trigger a refresh.  The 'load more messages' looks like it is probably safe if the option is selected.  Either way I think we want unit test cases covering both situations.


In terms of the UI presentation, it seems like it's a UX call about what to do.  In general, the most accurate statement we can make is that "there are no messages stored locally on the device right now, but there are more on the server."


This is a pretty big edge-case and UX is currently rate-limited, so I propose not addressing this as the current time.

Comment 2

[sarsenyev]

Attachment: 2013-10-07-19-40-35.png

Comment 3

[Jason Smith [:jsmith]]

To me, this feels worthy of a WONTFIX - I think the UX is fine and makes sense. What do you think Andrew?

Comment 4

[Andrew Sutherland [:asuth] (he/him)]

The screenshot has the text overlapping in a weird way, so I think we'd want to fix that no matter what, and I think consulting with UX is appropriate there.  If we close this we should spin off a bug on creating the (back-end) unit tests I mention because the testing method here creates a very innovative edge case.

Comment 8

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Attachment: Tarako Screenshot

Comment 11

[Andrew Sutherland [:asuth] (he/him)]

Juwei, it turns out that it's legal for us to locally have no messages in a folder but for us to believe there are messages on the server.  This results in us displaying both the "Load more messages from server" and "No mail in this folder" strings at the same time.  Visually, it ends up looking ugly.

There is a more recent screenshot available on bug 1117480 that demonstrates this.

I think our options are basically:
- Make the two displays interact better by changing their styling / HTML.
- Have a specialized string for this scenario so we're only showing one thing (see comment 1)
- Just hide the "No mail in this folder" message and leave it implied that there are no messages.

Comment 12

[Juwei Huang[:juwei]]

Hi Andrew,
I prefer the second option :)

Comment 14

[Oliver Nelson [:oliverthor]]

Attachment: flame_badui_emptyinbox_loadmessages.png

Comment 15

[Oliver Nelson [:oliverthor]]

This issue also reproes on flame devices on 3.0 [master]
Results: "Load more messages from server" still as a message alongside 'No mail in this Folder'

Environmental Variables:
Device: Flame 3.0
BuildID: 20150416010206
Gaia: 629097847567e51095a454e7e63186a6e2ac0307
Gecko: a35163f83d22
Gonk: b83fc73de7b64594cd74b33e498bf08332b5d87b
Version: 40.0a1 (3.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:40.0) Gecko/40.0 Firefox/40.0

Comment 16

[Teri Wen [:twen]]

Nominate for 3.0 work; bad user experience.

Comment 17

[sshir]

Attachment: 2015-07-27-12-55-40.png

Resolved - Works for me

Comment 18

[Dylan Oliver [:doliver]]

Suspect that this is a race condition and is probably not resolved. Not blocking 2.5 but will track this for potential fix in 2.5.

Comment 19

[BMO Automation]

Firefox OS is not being worked on