Closed
Bug 924500
Opened 11 years ago
Closed 11 years ago
Use outer-window-destroyed to detect windows have gone away
Categories
(Add-on SDK Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: mossop, Assigned: mossop)
Details
Attachments
(1 file)
Many of our tests hit problems with not waiting long enough for windows to close before continuing. Looks like the outer-window-destroyed notification is the very last thing after everything else so we should make the window.close callback only fire after that has happened.
|
Assignee | |
Comment 1•11 years ago
|
||
Pointer to Github pull-request
|
|
Assignee | |
Updated•11 years ago
|
Attachment #814615 -
Flags: review?(evold)
|
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → dtownsend+bugmail
|
||
Updated•11 years ago
|
Attachment #814615 -
Flags: review?(evold) → review+
|
||
Comment 2•11 years ago
|
||
Commits pushed to master at https://github.com/mozilla/addon-sdk https://github.com/mozilla/addon-sdk/commit/b160c665db28936cec268910f90890eb88406ab6 Bug 924500: Use outer-window-destroyed to detect when a window has been completely closed. https://github.com/mozilla/addon-sdk/commit/0bbe8c459117cc0a44edb9717a6f14b3fd0852ee Merge pull request #1260 from Mossop/bug924500 Bug 924500: Use outer-window-destroyed to detect when a window has been completely closed. r=erikvold
|
|
Assignee | |
Updated•11 years ago
|
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•