Documentation improvements

RESOLVED FIXED

Status

Testing Graveyard
Eideticker
RESOLVED FIXED
4 years ago
4 months ago

People

(Reporter: wlach, Assigned: wlach)

Tracking

Details

Attachments

(2 attachments)

I want to make a few improvements to the eideticker README:

1. Better documentation of the get-metric-for-build utility (in particular, we now support FirefoxOS there).
2. Various other nits (e.g. use of B2G instead of FirefoxOS)
Created attachment 814498 [details] [diff] [review]
0001-Bug-924535-Documentation-improvements-r-davehunt.patch

Minor improvements
Assignee: nobody → wlachance
Attachment #814498 - Flags: review?(dave.hunt)
Created attachment 814503 [details] [diff] [review]
0002-Bug-924535-Improve-documentation-for-getting-individ.patch

Better docs for getting individual results.
Attachment #814503 - Flags: review?(dave.hunt)

Updated

4 years ago
Attachment #814498 - Flags: review?(dave.hunt) → review+
Comment on attachment 814503 [details] [diff] [review]
0002-Bug-924535-Improve-documentation-for-getting-individ.patch

Review of attachment 814503 [details] [diff] [review]:
-----------------------------------------------------------------

::: README.md
@@ +172,4 @@
>  
>  ### Console profiling
>  
> +Console mode allows you to get one-off results of running eideticker for a

Can we capitalize Eideticker for consistency?

@@ +181,5 @@
> +To run get-metric-for-build against an already-installed version of
> +Fennec, specify the name of the test followed by the names of the
> +applications you want to test:
> +
> +    ./bin/get-metric-for-build.py <name of test> [app name 1] [app name 2] ...

For consistency, use <test>
Attachment #814503 - Flags: review?(dave.hunt) → review+
Pushed: 

https://github.com/mozilla/eideticker/commit/435c82b892761f49c870691840ae583c088a94e7
https://github.com/mozilla/eideticker/commit/3c3bb1669094c11f5bcf6527458da84ac97daa85
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED

Updated

4 months ago
Product: Testing → Testing Graveyard
You need to log in before you can comment on or make changes to this bug.