WebGL.getUniform should not throw

RESOLVED FIXED in mozilla28

Status

()

Core
Canvas: WebGL
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: bjacob, Assigned: bjacob)

Tracking

Trunk
mozilla28
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: webgl-conformance [qa-])

Attachments

(1 attachment)

Created attachment 814541 [details] [diff] [review]
patch

Some of the error reporting in WebGL.getUniform dates back to days when the earth crust was still warm from meteor impacts.
Attachment #814541 - Flags: review?(jgilbert)
Comment on attachment 814541 [details] [diff] [review]
patch

Review of attachment 814541 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/canvas/src/WebGLContextGL.cpp
@@ +1855,5 @@
>          }
>      }
>  
>      if (index == uniforms) {
> +        GenerateWarning("getUniform: internal error: hit an OpenGL driver bug");

I dream of a day when we get these reported via telemetry.
Attachment #814541 - Flags: review?(jgilbert) → review+
(Assignee)

Comment 2

4 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/eb6a7dcefb2f
Assignee: nobody → bjacob
Target Milestone: --- → mozilla28
https://hg.mozilla.org/mozilla-central/rev/eb6a7dcefb2f
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Whiteboard: webgl-conformance → webgl-conformance [qa-]
You need to log in before you can comment on or make changes to this bug.