Closed
Bug 924600
Opened 11 years ago
Closed 11 years ago
WebGL.getUniform should not throw
Categories
(Core :: Graphics: CanvasWebGL, defect)
Core
Graphics: CanvasWebGL
Tracking
()
RESOLVED
FIXED
mozilla28
People
(Reporter: bjacob, Assigned: bjacob)
Details
(Whiteboard: webgl-conformance [qa-])
Attachments
(1 file)
5.41 KB,
patch
|
jgilbert
:
review+
|
Details | Diff | Splinter Review |
Some of the error reporting in WebGL.getUniform dates back to days when the earth crust was still warm from meteor impacts.
Attachment #814541 -
Flags: review?(jgilbert)
Comment 1•11 years ago
|
||
Comment on attachment 814541 [details] [diff] [review] patch Review of attachment 814541 [details] [diff] [review]: ----------------------------------------------------------------- ::: content/canvas/src/WebGLContextGL.cpp @@ +1855,5 @@ > } > } > > if (index == uniforms) { > + GenerateWarning("getUniform: internal error: hit an OpenGL driver bug"); I dream of a day when we get these reported via telemetry.
Attachment #814541 -
Flags: review?(jgilbert) → review+
Assignee | ||
Comment 2•11 years ago
|
||
http://hg.mozilla.org/integration/mozilla-inbound/rev/eb6a7dcefb2f
Assignee: nobody → bjacob
Target Milestone: --- → mozilla28
Comment 3•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/eb6a7dcefb2f
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•