924639 - jit_test.py should print test paths relative to the same root as it expects its inputs

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement)

Description

[Dan Gohman [:sunfish]]

Attachment: jit-test-relpath.patch

jit_test.py's commandline can contain the names of tests to run, which are relative to js/src/jit-tests/tests. However, when a test fails or times out, it prints the test names relative to js/src. This makes it inconvenient to copy and past test names. The attached patch changes the output to print test names relative to js/src/jit-tests/tests so that they match what the script expects for input.

Comment 1

[Terrence Cole [:terrence]]

Comment on attachment 814575 [details] [diff] [review]
jit-test-relpath.patch

Review of attachment 814575 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for fixing this, I've been meaning to do it myself for ages.

::: js/src/tests/lib/jittests.py
@@ +77,5 @@
>          # Path relative to the top mozilla/ directory.
>          self.relpath_top = os.path.relpath(path, TOP_SRC_DIR)
>  
> +        # Path relative to mozilla/js/src/jit-test/tests/.
> +        self.relpath_test = os.path.relpath(path, TEST_DIR)

I named this self.relpath_tests in bug 924481: could you call it that here to cut down on my rebasing woes?

Comment 2

[Terrence Cole [:terrence]]

Also, CCing in some sheriffs as this may impact some of their tools.

Comment 3

[Ed Morley [:emorley]]

Thank you for the heads up - in this case, shouldn't impact us at all :-)

Comment 4

[Dan Gohman [:sunfish]]

(In reply to Terrence Cole [:terrence] from comment #1)
> @@ +77,5 @@
> >          # Path relative to the top mozilla/ directory.
> >          self.relpath_top = os.path.relpath(path, TOP_SRC_DIR)
> >  
> > +        # Path relative to mozilla/js/src/jit-test/tests/.
> > +        self.relpath_test = os.path.relpath(path, TEST_DIR)
> 
> I named this self.relpath_tests in bug 924481: could you call it that here
> to cut down on my rebasing woes?

Done. https://hg.mozilla.org/integration/mozilla-inbound/rev/a23f880b3bcb

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a23f880b3bcb