924658 - Only provide one explicit function for converting a WeakPtrBase into a T*

Status: NEW

(Core :: MFBT, defect)

Description

[(no longer active)]

See bug 923554 for the reasoning.  Specifically I think we should remove all three operators from that class and stick to calling get() explicitly.

Comment 1

[(no longer active)]

Attachment: WIP!

I took a stab at this.  Of course this breaks the build in all sorts of ways, and the code using WeakPtr should be audited carefully to see if the weak pointers are being used in safe ways.

Comment 2

[(no longer active)]

I posted about this to dev.platform.

Comment 3

[Chris Peterson [:cpeterson]]

Don't forget to update the example code using a WeakPtr in a boolean context! :)

https://hg.mozilla.org/mozilla-central/file/552bca1bc885/mfbt/WeakPtr.h#l43

Comment 4

[(no longer active)]

(In reply to comment #3)
> Don't forget to update the example code using a WeakPtr in a boolean context!
> :)
> 
> https://hg.mozilla.org/mozilla-central/file/552bca1bc885/mfbt/WeakPtr.h#l43

Haha good catch, we should probably do a SafeBool thingy here <http://www.artima.com/cppsource/safebool.html>