924699 - RTL support for Top Sites

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Theme and Visual Design, defect, P1)

Description

[Niv Yahel]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:24.0) Gecko/20100101 Firefox/24.0 (Beta/Release)
Build ID: 20130910160258

Steps to reproduce:

I'm working towards making the Top Sites component of the Homepage compatible with RTL. I will be making bugs "blocking" this bug as I conquer smaller components of it.

Comment 1

[Itiel]

Seems to be working OK in latest Nightly builds.

Comment 2

[Rachelle Yang [:ryang][[e-mail]]]

Hi Ioana, would you please help us verify this RTL support on Fennec after Bug 1319302 is already resolved fixed ? 
Could you help us create the complete RTL test cases  and its corresponding wiki test page for tracking ?
Thank you!

Comment 3

[Itiel]

I'd still like to someone having a tablet to verify this is indeed fixed on tablet phones.

Comment 4

[Sorina Florean [:sflorean]]

Hi Rachelle, I am providing information behalf of Ioana.
Here is the Test Plan for RTL support on Fennec: https://wiki.mozilla.org/QA/Fennec/Support_RTL.

Tested RTL support for Top Sites on latest Nightly (Arabic) and the results:
Phone:
- LG G4 (Android 5.1) - https://i.imgur.com/WNKt9Pq.png
- Lenovo A536 (Android 4.4.2) - https://i.imgur.com/0o8ZZmK.png 
Tablet:
- Nexus 9 (Android 7.0) - https://i.imgur.com/t6qFFGN.png
- Asus ZenPad 8 (Android 6.0.1) - https://i.imgur.com/ZjynFhL.png

Comment 5

[Itiel]

(In reply to ItielMaN from comment #1)
> Seems to be working OK in latest Nightly builds.

I take it back.
On my device (Samsung Galaxy S5 G900F Android 6.0.1):
1. Bookmarked pages have no blue star next to it (but they appear in the history page)
2. As stated by Niv Yahel in bug 924700 comment 1, the text in the grid view does not support BiDi
3. bug 1321633 applies here as well

Comment 6

[Ioana Chiorean]

ItielMaN can you please check again with latest builds?

I am seeing the blue star at bookmarks and the fading issues is fixed.

Comment 7

[Ioana Chiorean]

This was implemented and works correctly - further bugs that might arise will be linked here for tracking

Comment 8

[Itiel]

(In reply to Ioana Chiorean from comment #6)
> ItielMaN can you please check again with latest builds?
> 
> I am seeing the blue star at bookmarks and the fading issues is fixed.

Yep, the blue star seems to be fixed as well.