9247 - Compiler warnings in mozilla/network/cache/mkcache.c, extcache.c

Status: VERIFIED FIXED

(Core :: Networking: Cache, defect, P3)

Description

[Kenneth Herron]

Much of this was prompted by the fact that size_t is unsigned on linux, so
using an int where a size_t is expected (e.g. the argument to malloc())
generates a compiler warning.

extcache.c:  Patch removes about eleven warnings.  Also, the return value of
net_GetInt32InCacheDBT() was a time_t where it seemed it should be an int32;
the patch fixes that.

extcache.h:  Patch corrects the prototype for net_GetInt32etc. to match
extcache.c.

mkcache.c:  corrects the definition of the PUT_PART() macro.  This macro is
used about 30 times and each use generated a warning.  Patch also fixes
several other minor issues.

Comment 1

[Kenneth Herron]

Attachment: mozilla/network/cache/extcache.c patch

Comment 2

[Kenneth Herron]

Attachment: mozilla/network/cache/extcache.h patch

Comment 3

[Kenneth Herron]

Attachment: mozilla/network/cache/mkcache.c patch

Comment 4

[Gagan]

Past necko landing...

Comment 5

[Gagan]

Deferred till cache lands.

Comment 6

[Gagan]

that code is being obsoleted.

Comment 7

[leger]

Bulk move of all Cache (to be deleted component) bugs to new Networking: Cache
component.