Compiler warnings in mozilla/network/cache/mkcache.c, extcache.c

VERIFIED FIXED in M10

Status

()

Core
Networking: Cache
P3
trivial
VERIFIED FIXED
19 years ago
19 years ago

People

(Reporter: Kenneth Herron, Assigned: Gagan)

Tracking

Trunk
x86
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

(Reporter)

Description

19 years ago
Much of this was prompted by the fact that size_t is unsigned on linux, so
using an int where a size_t is expected (e.g. the argument to malloc())
generates a compiler warning.

extcache.c:  Patch removes about eleven warnings.  Also, the return value of
net_GetInt32InCacheDBT() was a time_t where it seemed it should be an int32;
the patch fixes that.

extcache.h:  Patch corrects the prototype for net_GetInt32etc. to match
extcache.c.

mkcache.c:  corrects the definition of the PUT_PART() macro.  This macro is
used about 30 times and each use generated a warning.  Patch also fixes
several other minor issues.
(Reporter)

Comment 1

19 years ago
Created attachment 687 [details] [diff] [review]
mozilla/network/cache/extcache.c patch
(Reporter)

Comment 2

19 years ago
Created attachment 688 [details] [diff] [review]
mozilla/network/cache/extcache.h patch
(Reporter)

Comment 3

19 years ago
Created attachment 689 [details] [diff] [review]
mozilla/network/cache/mkcache.c patch
(Assignee)

Comment 4

19 years ago
Past necko landing...
(Assignee)

Updated

19 years ago
Target Milestone: M9 → M10
(Assignee)

Comment 5

19 years ago
Deferred till cache lands.
(Assignee)

Updated

19 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 19 years ago
Resolution: --- → FIXED
(Assignee)

Comment 6

19 years ago
that code is being obsoleted.

Updated

19 years ago
Status: RESOLVED → VERIFIED

Comment 7

19 years ago
Bulk move of all Cache (to be deleted component) bugs to new Networking: Cache
component.
You need to log in before you can comment on or make changes to this bug.