92473 - Overwrite character set does not work inside Text and Textarea.

Status: VERIFIED FIXED

(Core :: Internationalization, defect)

Description

[Teruko Kobayashi]

Overwrite character set does not work inside Text and Textarea.

Steps of reproduce
1. Launch Browser
2. Clean the cash or creat new profile
3. Go to the following urls 
http://babel/tests/browser/html/sjis_no_meta/test-text_sjis.html for text
http://babel/tests/browser/html/sjis_no_meta/test-form_sjis1.html for textarea

Since these page do not have meta charset info, Japanese characters are 
not displayed correctly.

4. Select menu View | Character coding->More->East Asain->Japanese (Shift_JIS)

Actual result,
Inside Text and TextArea, Japanese characters are not displayed correctly.

Expected result,
Inside Text and TextArea, Japanese characters are diaplayed correctly.

Tested 7-25-0.9.2 Win32, Mac, and Linux build.
I tested this in 6.1 PR1.  I could reproduce this.

Comment 1

[nhottanscp]

Reassign to shanjian.

Comment 2

[Shanjian Li]

For normal reload or charset reload, the content of text field and textarea are 
preserved. This is an unwanted feature in case of charset reload. I am still 
looking for the place where this preservation is done. 

Comment 3

[Shanjian Li]

Attachment: Proposed fix,

Comment 4

[Shanjian Li]

radha, could you review my fix? That change in nsDocShell.cpp is most sensitive.
thanks!

Comment 5

[Radha on family leave (not reading bugmail)]

The patch looks good, as long as it avoids the historystate restoration *only*
for charset change. Please make sure that  form field values are restored for
simple reloads.

r=radha

Comment 6

[Shanjian Li]

Yes, for normal reload, text field values are restored.

Comment 7

[Shanjian Li]

blizzard, can you sr this one?

Comment 8

[Christopher Blizzard (:blizzard)]

sr=blizzard

Comment 9

[Shanjian Li]

fix checked in. 

Comment 10

[Teruko Kobayashi]

Verified as fixed in 8-22 trunk build.

Comment 11

[Simon Montagu :smontagu]

Attachment: testcase

I imagine the testcase was something like this.

Comment 12

[Simon Montagu :smontagu]

Attachment: test input testcase

Comment 13

[Simon Montagu :smontagu]

Attachment: Regression test