924734 - Check for duplicate title during publishing phase

Status: RESOLVED FIXED

(Webmaker Graveyard :: Thimble, defect)

Description

[Brett Gaylor [:brett]]

STR:

1) Go to https://webmaker.org/starter-makes
2) Choose the book cover make
3) change something, publish it
4) Click remix and change another thing, publish it, but don't change the title in the dialogue that prompts for a title
5) notice the blue box gives you an error for duplicate title and closes the meta data dialogue

What is annoying about this is that the blue dialogue doesn't tell you that it was in the previous modal that you could fix this - I spent some time changing the <title> only to have the same error come up, and I thought it was a bug until I remembered that it was in this new dialogue you had to change the title.

Why not instead give this error in the new modal, and just refuse to publish?  Give some red text in there, highlight the input field for title?

Comment 1

[Pomax]

I'm pretty sure we added in code that was supposed to pick up a new title if <title> got changed. Pinging thecount: did we review but not land that, or did we cancel on that decision? (I know we cancelled on reflecting the title from the dialog back into the document, but i thought we kept the document to dialog copy)

Comment 2

[Scott [:thecount] Downe]

@Pomax:

We updated it so title was a different thing from the make's name. We did this in bug 917402

So if the page's title is changed, it does not change the name of the make. Only if there is no name, does it try to use the title.

I think this is still kinda weird, but you can see in bug 917402 why we decided on this for now.

An advantage to this is later we can make it so title in the html no longer has to be unique. Think of name as the name of the html file. The thing you see in the url. Example, index.html is the filename, and in the html, it has a title, then can be the same if the user choses, or different if they choose, but in the future title no longer has to be unique, only name. Just the webpages.

@Brett:

I agree though, publish errors should be displayed in the publish dialog next to the field that needs fixing. That's 100 times better!

Comment 3

[Brett Gaylor [:brett]]

As discussed in meeting:

This bug should warn the user of a title collision within the first modal.  ie it should check on publish and warn if it exists, vs sending them to another unfriendly screen.

Comment 5

[Pomax]

Attachment: https://github.com/mozilla/thimble.webmaker.org/pull/255

Comment 6

[Pomax]

Comment on attachment 817422 [details] [review]
https://github.com/mozilla/thimble.webmaker.org/pull/255

will also kick in on a legitimate  /edit link

Comment 7

[Pomax]

Comment on attachment 817422 [details] [review]
https://github.com/mozilla/thimble.webmaker.org/pull/255

I've made the "is this title taken?" similar to a publication post, using some of the same bits of page information that a regular publish uses to determine whether a page is a remix or an edit, and ride the result of that check, in combination with a "does a project by this title already exist for this user" db query to see whether a) the title is in use, and b) if it is, whether that's for the page that the user is currently editing. If either of those is false, then a duplicate title is flagged as "you cannot use this title". Otherwise, the title is allowed.

Comment 8

[Scott [:thecount] Downe]

Comment on attachment 817422 [details] [review]
https://github.com/mozilla/thimble.webmaker.org/pull/255

Amazing! r+

Comment 9

[[github robot]]

Commit pushed to master at https://github.com/mozilla/thimble.webmaker.org

https://github.com/mozilla/thimble.webmaker.org/commit/14fa3368be2e7b2227e7dcdd5f7c55280ed6b6a5
Merge pull request #255 from Pomax/bug924734

titles are now checked for elligibility before allowing publication