924736 - [Dialer] Incoming call lock screen icons css/animation fine-tune

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Steve Chung [:steveck]]

+++ Clone of Bug #923788 and add more follow up tuning based on UX feedback+++

1. Ensure the lock screen handle looks correct on non-320px wide mobile screens.
2. Add swipper expending animation while call hang up/pick up triggered.
3. Ensure the swipper bar length matches the container perfectly. (call hang up side has 1px mismatched currently).

Comment 1

[Steve Chung [:steveck]]

Attachment: pull-request.html

Hi Etienne, this patch may still need hdpi image asset for completion. Would you mind take a quick look first? I'll set review once the image assets are ready, thnaks.

Comment 2

[Joe Cheng [:jcheng] (please needinfo)]

hi Steve, do you think you can upload a video of the incoming call without these patches? it will be easier to decide if this is a blocker after seeing the video
thanks

Comment 3

[Etienne Segonzac (:etienne)]

Comment on attachment 818506 [details]
pull-request.html

Looks like the fix for the the glitches here is diverging from the one on the system lockscreen [1].

I'd like to keep the code as close as possible between the 2 sliders, is there something preventing us from doing this here?

[1] https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/lockscreen.js#L1293

Comment 4

[Steve Chung [:steveck]]

(In reply to Joe Cheng [:jcheng] from comment #2)
> hi Steve, do you think you can upload a video of the incoming call without
> these patches? it will be easier to decide if this is a blocker after seeing
> the video
> thanks

Hi Joe, I add the the video to demonstrate the changes after patch applied:
https://docs.google.com/file/d/0B7CDMebivgCGZldKa3NEd2tZTDg/edit?usp=sharing

Comment 5

[Steve Chung [:steveck]]

Comment on attachment 818506 [details]
pull-request.html

Thanks for the reminder, I also adjust the layout to fit the current system lockscreen now.

Comment 6

[Etienne Segonzac (:etienne)]

Comment on attachment 818506 [details]
pull-request.html

Much better, thanks!
Did some comments on github.

Feel free to ask for a review directly once the hd version is ready we're very close.

Comment 7

[Steve Chung [:steveck]]

Hi Patryk, could you also provide the HD arrow icon images(1.5x and 2x)? I think system lockscreen also need this, thanks.

Comment 8

[Preeti Raghunath(:Preeti)]

Steve,

Not sure why this needs to block koi.

Is this a new feature? or an enhancement?

Comment 9

[Joe Cheng [:jcheng] (please needinfo)]

triage: should not block release. please ask for approval to land in v1.2 thanks

Comment 10

[Steve Chung [:steveck]]

Comment on attachment 818506 [details]
pull-request.html

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
[User impact] if declined:
[Testing completed]:
[Risk to taking this patch] (and alternatives if risky):
[String changes made]:

Comment 11

[Steve Chung [:steveck]]

(In reply to Preeti Raghunath(:Preeti) from comment #8)
> Steve,
> 
> Not sure why this needs to block koi.
> 
> Is this a new feature? or an enhancement?

Hi Preeti, I'll reply within approval-gaia-v1.2 request, thanks.

Comment 12

[Steve Chung [:steveck]]

[Approval Request Comment] 
[Bug caused by] (feature/regressing bug #): Bug 913378 and Bug 916037. It's a follow-up fixing based on latest lockscrren design since system lockscreen layout/behavior has changed recently.
[User impact] if declined: 
1) Layout between current system lockscreen and incoming call lockscrenn will be different
2) Small layout/behavior polishing.
[Testing completed]: Yes with unit test.
[Risk to taking this patch] (and alternatives if risky): Should be small. Most of the chages are layout related only.
[String changes made]:None

Comment 13

[Steve Chung [:steveck]]

Comment on attachment 818506 [details]
pull-request.html

Hi Etienne, I've updated the patch with HD image, thanks for the previous feedbacks.

Comment 14

[Etienne Segonzac (:etienne)]

Comment on attachment 818506 [details]
pull-request.html

r=me with nits addressed

Glad to see this patch land!

Comment 15

[Steve Chung [:steveck]]

Thanks for the review!
Merged in master: e2d3834d9cf17fe7e792046a207e19eb6509a049

Set status-b2g-v1.2 affected flag since this patch already granted Tim's approval for v1.2

Comment 16

[Steve Chung [:steveck]]

Merged in v1.2:3e67ddf7d2680d1ef01441641f4ca2e0e4006887